mirror of
https://github.com/nodejs/node.git
synced 2025-05-06 00:30:06 +00:00

The source context is not prepended to the value of the `stack` property when the source map is not enabled. Rather than prepending the error source context to the value of the `stack` property unconditionally, this patch aligns the behavior and only prints the source context when the error is not handled by userland (e.g. fatal errors). Also, this patch fixes that when source-map support is enabled, the error source context is not pointing to where the error was thrown. PR-URL: https://github.com/nodejs/node/pull/43875 Fixes: https://github.com/nodejs/node/issues/43186 Fixes: https://github.com/nodejs/node/issues/41541 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
214 lines
7.2 KiB
JavaScript
214 lines
7.2 KiB
JavaScript
'use strict';
|
|
|
|
const {
|
|
ArrayPrototypeIndexOf,
|
|
ArrayPrototypeJoin,
|
|
ArrayPrototypeMap,
|
|
ErrorPrototypeToString,
|
|
RegExpPrototypeSymbolSplit,
|
|
StringPrototypeRepeat,
|
|
StringPrototypeSlice,
|
|
StringPrototypeStartsWith,
|
|
SafeStringIterator,
|
|
} = primordials;
|
|
|
|
let debug = require('internal/util/debuglog').debuglog('source_map', (fn) => {
|
|
debug = fn;
|
|
});
|
|
const { getStringWidth } = require('internal/util/inspect');
|
|
const { readFileSync } = require('fs');
|
|
const { findSourceMap } = require('internal/source_map/source_map_cache');
|
|
const {
|
|
kNoOverride,
|
|
overrideStackTrace,
|
|
maybeOverridePrepareStackTrace,
|
|
kIsNodeError,
|
|
} = require('internal/errors');
|
|
const { fileURLToPath } = require('internal/url');
|
|
const { setGetSourceMapErrorSource } = internalBinding('errors');
|
|
|
|
// Create a prettified stacktrace, inserting context from source maps
|
|
// if possible.
|
|
const prepareStackTrace = (globalThis, error, trace) => {
|
|
// API for node internals to override error stack formatting
|
|
// without interfering with userland code.
|
|
// TODO(bcoe): add support for source-maps to repl.
|
|
if (overrideStackTrace.has(error)) {
|
|
const f = overrideStackTrace.get(error);
|
|
overrideStackTrace.delete(error);
|
|
return f(error, trace);
|
|
}
|
|
|
|
const globalOverride =
|
|
maybeOverridePrepareStackTrace(globalThis, error, trace);
|
|
if (globalOverride !== kNoOverride) return globalOverride;
|
|
|
|
let errorString;
|
|
if (kIsNodeError in error) {
|
|
errorString = `${error.name} [${error.code}]: ${error.message}`;
|
|
} else {
|
|
errorString = ErrorPrototypeToString(error);
|
|
}
|
|
|
|
if (trace.length === 0) {
|
|
return errorString;
|
|
}
|
|
|
|
let lastSourceMap;
|
|
let lastFileName;
|
|
const preparedTrace = ArrayPrototypeJoin(ArrayPrototypeMap(trace, (t, i) => {
|
|
const str = i !== 0 ? '\n at ' : '';
|
|
try {
|
|
// A stack trace will often have several call sites in a row within the
|
|
// same file, cache the source map and file content accordingly:
|
|
let fileName = t.getFileName();
|
|
if (fileName === undefined) {
|
|
fileName = t.getEvalOrigin();
|
|
}
|
|
const sm = fileName === lastFileName ?
|
|
lastSourceMap :
|
|
findSourceMap(fileName);
|
|
lastSourceMap = sm;
|
|
lastFileName = fileName;
|
|
if (sm) {
|
|
// Source Map V3 lines/columns start at 0/0 whereas stack traces
|
|
// start at 1/1:
|
|
const {
|
|
originalLine,
|
|
originalColumn,
|
|
originalSource,
|
|
} = sm.findEntry(t.getLineNumber() - 1, t.getColumnNumber() - 1);
|
|
if (originalSource && originalLine !== undefined &&
|
|
originalColumn !== undefined) {
|
|
const name = getOriginalSymbolName(sm, trace, i);
|
|
// Construct call site name based on: v8.dev/docs/stack-trace-api:
|
|
const fnName = t.getFunctionName() ?? t.getMethodName();
|
|
const typeName = t.getTypeName();
|
|
const namePrefix = typeName !== null && typeName !== 'global' ? `${typeName}.` : '';
|
|
const originalName = `${namePrefix}${fnName || '<anonymous>'}`;
|
|
// The original call site may have a different symbol name
|
|
// associated with it, use it:
|
|
const prefix = (name && name !== originalName) ?
|
|
`${name}` :
|
|
`${originalName}`;
|
|
const hasName = !!(name || originalName);
|
|
const originalSourceNoScheme =
|
|
StringPrototypeStartsWith(originalSource, 'file://') ?
|
|
fileURLToPath(originalSource) : originalSource;
|
|
// Replace the transpiled call site with the original:
|
|
return `${str}${prefix}${hasName ? ' (' : ''}` +
|
|
`${originalSourceNoScheme}:${originalLine + 1}:` +
|
|
`${originalColumn + 1}${hasName ? ')' : ''}`;
|
|
}
|
|
}
|
|
} catch (err) {
|
|
debug(err);
|
|
}
|
|
return `${str}${t}`;
|
|
}), '');
|
|
return `${errorString}\n at ${preparedTrace}`;
|
|
};
|
|
|
|
// Transpilers may have removed the original symbol name used in the stack
|
|
// trace, if possible restore it from the names field of the source map:
|
|
function getOriginalSymbolName(sourceMap, trace, curIndex) {
|
|
// First check for a symbol name associated with the enclosing function:
|
|
const enclosingEntry = sourceMap.findEntry(
|
|
trace[curIndex].getEnclosingLineNumber() - 1,
|
|
trace[curIndex].getEnclosingColumnNumber() - 1
|
|
);
|
|
if (enclosingEntry.name) return enclosingEntry.name;
|
|
// Fallback to using the symbol name attached to the next stack frame:
|
|
const currentFileName = trace[curIndex].getFileName();
|
|
const nextCallSite = trace[curIndex + 1];
|
|
if (nextCallSite && currentFileName === nextCallSite.getFileName()) {
|
|
const { name } = sourceMap.findEntry(
|
|
nextCallSite.getLineNumber() - 1,
|
|
nextCallSite.getColumnNumber() - 1
|
|
);
|
|
return name;
|
|
}
|
|
}
|
|
|
|
// Places a snippet of code from where the exception was originally thrown
|
|
// above the stack trace. This logic is modeled after GetErrorSource in
|
|
// node_errors.cc.
|
|
function getErrorSource(
|
|
sourceMap,
|
|
originalSourcePath,
|
|
originalLine,
|
|
originalColumn
|
|
) {
|
|
let exceptionLine = '';
|
|
const originalSourcePathNoScheme =
|
|
StringPrototypeStartsWith(originalSourcePath, 'file://') ?
|
|
fileURLToPath(originalSourcePath) : originalSourcePath;
|
|
const source = getOriginalSource(
|
|
sourceMap.payload,
|
|
originalSourcePath
|
|
);
|
|
const lines = RegExpPrototypeSymbolSplit(/\r?\n/, source, originalLine + 1);
|
|
const line = lines[originalLine];
|
|
if (!line) return exceptionLine;
|
|
|
|
// Display ^ in appropriate position, regardless of whether tabs or
|
|
// spaces are used:
|
|
let prefix = '';
|
|
for (const character of new SafeStringIterator(
|
|
StringPrototypeSlice(line, 0, originalColumn + 1))) {
|
|
prefix += character === '\t' ? '\t' :
|
|
StringPrototypeRepeat(' ', getStringWidth(character));
|
|
}
|
|
prefix = StringPrototypeSlice(prefix, 0, -1); // The last character is '^'.
|
|
|
|
exceptionLine =
|
|
`${originalSourcePathNoScheme}:${originalLine + 1}\n${line}\n${prefix}^\n\n`;
|
|
return exceptionLine;
|
|
}
|
|
|
|
function getOriginalSource(payload, originalSourcePath) {
|
|
let source;
|
|
// payload.sources has been normalized to be an array of absolute urls.
|
|
const sourceContentIndex =
|
|
ArrayPrototypeIndexOf(payload.sources, originalSourcePath);
|
|
if (payload.sourcesContent?.[sourceContentIndex]) {
|
|
// First we check if the original source content was provided in the
|
|
// source map itself:
|
|
source = payload.sourcesContent[sourceContentIndex];
|
|
} else if (StringPrototypeStartsWith(originalSourcePath, 'file://')) {
|
|
// If no sourcesContent was found, attempt to load the original source
|
|
// from disk:
|
|
debug(`read source of ${originalSourcePath} from filesystem`);
|
|
const originalSourcePathNoScheme = fileURLToPath(originalSourcePath);
|
|
try {
|
|
source = readFileSync(originalSourcePathNoScheme, 'utf8');
|
|
} catch (err) {
|
|
debug(err);
|
|
source = '';
|
|
}
|
|
} else {
|
|
source = '';
|
|
}
|
|
return source;
|
|
}
|
|
|
|
function getSourceMapErrorSource(fileName, lineNumber, columnNumber) {
|
|
const sm = findSourceMap(fileName);
|
|
if (sm === null) {
|
|
return;
|
|
}
|
|
const {
|
|
originalLine,
|
|
originalColumn,
|
|
originalSource,
|
|
} = sm.findEntry(lineNumber - 1, columnNumber);
|
|
const errorSource = getErrorSource(sm, originalSource, originalLine, originalColumn);
|
|
return errorSource;
|
|
}
|
|
|
|
setGetSourceMapErrorSource(getSourceMapErrorSource);
|
|
|
|
module.exports = {
|
|
prepareStackTrace,
|
|
};
|