mirror of
https://github.com/nodejs/node.git
synced 2025-05-06 03:45:25 +00:00
800c32d315
[kFinish](code) can be triggered from a 'finish' event (for example when calling response.end) which does not pass code. That tries to set closedCode to undefined resulting in NaN closedCode instead of NGHTTP2_NO_ERROR. Check for code !== undefined before setting. Adds tests for closed and closedCode. PR-URL: https://github.com/nodejs/node/pull/15154 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
60 lines
1.8 KiB
JavaScript
60 lines
1.8 KiB
JavaScript
// Flags: --expose-http2
|
|
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const h2 = require('http2');
|
|
const net = require('net');
|
|
|
|
// Http2ServerRequest should expose convenience properties
|
|
|
|
const server = h2.createServer();
|
|
server.listen(0, common.mustCall(function() {
|
|
const port = server.address().port;
|
|
server.once('request', common.mustCall(function(request, response) {
|
|
const expected = {
|
|
statusCode: null,
|
|
version: '2.0',
|
|
httpVersionMajor: 2,
|
|
httpVersionMinor: 0
|
|
};
|
|
|
|
assert.strictEqual(request.closed, false);
|
|
assert.strictEqual(request.code, h2.constants.NGHTTP2_NO_ERROR);
|
|
|
|
assert.strictEqual(request.statusCode, expected.statusCode);
|
|
assert.strictEqual(request.httpVersion, expected.version);
|
|
assert.strictEqual(request.httpVersionMajor, expected.httpVersionMajor);
|
|
assert.strictEqual(request.httpVersionMinor, expected.httpVersionMinor);
|
|
|
|
assert.ok(request.socket instanceof net.Socket);
|
|
assert.ok(request.connection instanceof net.Socket);
|
|
assert.strictEqual(request.socket, request.connection);
|
|
|
|
response.on('finish', common.mustCall(function() {
|
|
assert.strictEqual(request.closed, true);
|
|
assert.strictEqual(request.code, h2.constants.NGHTTP2_NO_ERROR);
|
|
server.close();
|
|
}));
|
|
response.end();
|
|
}));
|
|
|
|
const url = `http://localhost:${port}`;
|
|
const client = h2.connect(url, common.mustCall(function() {
|
|
const headers = {
|
|
':path': '/foobar',
|
|
':method': 'GET',
|
|
':scheme': 'http',
|
|
':authority': `localhost:${port}`
|
|
};
|
|
const request = client.request(headers);
|
|
request.on('end', common.mustCall(function() {
|
|
client.destroy();
|
|
}));
|
|
request.end();
|
|
request.resume();
|
|
}));
|
|
}));
|