mirror of
https://github.com/nodejs/node.git
synced 2025-05-09 06:51:42 +00:00

This fixes validating an ArrayBufferView given to ReadableStreamBYOBRequest.respondWithNewView() to improve the web streams compatibility. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: https://github.com/nodejs/node/pull/43866 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
55 lines
1.4 KiB
JavaScript
55 lines
1.4 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('node:assert');
|
|
|
|
let pass = 0;
|
|
|
|
{
|
|
// ReadableStream with byte source: respondWithNewView() throws if the
|
|
// supplied view's buffer has a different length (in the closed state)
|
|
const stream = new ReadableStream({
|
|
pull: common.mustCall(async (c) => {
|
|
const view = new Uint8Array(new ArrayBuffer(10), 0, 0);
|
|
|
|
c.close();
|
|
|
|
assert.throws(() => c.byobRequest.respondWithNewView(view), {
|
|
code: 'ERR_INVALID_ARG_VALUE',
|
|
name: 'RangeError',
|
|
});
|
|
pass++;
|
|
}),
|
|
type: 'bytes',
|
|
});
|
|
|
|
const reader = stream.getReader({ mode: 'byob' });
|
|
reader.read(new Uint8Array([4, 5, 6]));
|
|
}
|
|
|
|
{
|
|
// ReadableStream with byte source: respondWithNewView() throws if the
|
|
// supplied view's buffer has been detached (in the closed state)
|
|
const stream = new ReadableStream({
|
|
pull: common.mustCall((c) => {
|
|
c.close();
|
|
|
|
// Detach it by reading into it
|
|
const view = new Uint8Array([1, 2, 3]);
|
|
reader.read(view);
|
|
|
|
assert.throws(() => c.byobRequest.respondWithNewView(view), {
|
|
code: 'ERR_INVALID_STATE',
|
|
name: 'TypeError',
|
|
});
|
|
pass++;
|
|
}),
|
|
type: 'bytes',
|
|
});
|
|
|
|
const reader = stream.getReader({ mode: 'byob' });
|
|
reader.read(new Uint8Array([4, 5, 6]));
|
|
}
|
|
|
|
process.on('exit', () => assert.strictEqual(pass, 2));
|