mirror of
https://github.com/nodejs/node.git
synced 2025-05-08 23:23:46 +00:00
1dafaf03cb
There's a typo that causes only the first socket to be logged (i.e. when the warning is emitted). In addition, server sockets aren't logged because `keylog` events are not emitted on tls.Server, not the socket. This behaviour is counterintuitive and has caused more bugs in the past, so make all sockets (server or client) emit 'keylog'. tls.Server will just re-emit these events. Refs: https://github.com/nodejs/node/pull/30055 PR-URL: https://github.com/nodejs/node/pull/33366 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
63 lines
1.6 KiB
JavaScript
63 lines
1.6 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
if (!common.hasCrypto) common.skip('missing crypto');
|
|
const fixtures = require('../common/fixtures');
|
|
|
|
// Test --tls-keylog CLI flag.
|
|
|
|
const assert = require('assert');
|
|
const path = require('path');
|
|
const fs = require('fs');
|
|
const { fork } = require('child_process');
|
|
|
|
if (process.argv[2] === 'test')
|
|
return test();
|
|
|
|
const tmpdir = require('../common/tmpdir');
|
|
tmpdir.refresh();
|
|
const file = path.resolve(tmpdir.path, 'keylog.log');
|
|
|
|
const child = fork(__filename, ['test'], {
|
|
execArgv: ['--tls-keylog=' + file]
|
|
});
|
|
|
|
child.on('close', common.mustCall((code, signal) => {
|
|
assert.strictEqual(code, 0);
|
|
assert.strictEqual(signal, null);
|
|
const log = fs.readFileSync(file, 'utf8').trim().split('\n');
|
|
// Both client and server should log their secrets,
|
|
// so we should have two identical lines in the log
|
|
assert.strictEqual(log.length, 2);
|
|
assert.strictEqual(log[0], log[1]);
|
|
}));
|
|
|
|
function test() {
|
|
const {
|
|
connect, keys
|
|
} = require(fixtures.path('tls-connect'));
|
|
|
|
connect({
|
|
client: {
|
|
checkServerIdentity: (servername, cert) => { },
|
|
ca: `${keys.agent1.cert}\n${keys.agent6.ca}`,
|
|
},
|
|
server: {
|
|
cert: keys.agent6.cert,
|
|
key: keys.agent6.key,
|
|
// Number of keylog events is dependent on protocol version
|
|
maxVersion: 'TLSv1.2',
|
|
},
|
|
}, common.mustCall((err, pair, cleanup) => {
|
|
if (pair.server.err) {
|
|
console.trace('server', pair.server.err);
|
|
}
|
|
if (pair.client.err) {
|
|
console.trace('client', pair.client.err);
|
|
}
|
|
assert.ifError(pair.server.err);
|
|
assert.ifError(pair.client.err);
|
|
|
|
return cleanup();
|
|
}));
|
|
}
|