mirror of
https://github.com/nodejs/node.git
synced 2025-05-09 00:55:45 +00:00
9cde7a033e
In the manual page, there is a statement that ciphersuites contain explicit default settings - all TLS 1.3 ciphersuites enabled. In node, we assume that an empty setting mean no ciphersuites and we disable TLS 1.3. A correct approach to disabling TLS 1.3 is to disable TLS 1.3 and by not override the default ciphersuits with an empty string. So, only override OpenSSL's TLS 1.3 ciphersuites with an explicit list of ciphers. If none are acceptable, the correct approach is to disable TLS 1.3 instead elsewhere. Fixes: https://github.com/nodejs/node/issues/43419 PR-URL: https://github.com/nodejs/node/pull/43427 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: James M Snell <jasnell@gmail.com>
63 lines
1.8 KiB
JavaScript
63 lines
1.8 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const fixtures = require('../common/fixtures');
|
|
|
|
const assert = require('assert');
|
|
const tls = require('tls');
|
|
|
|
const key = fixtures.readKey('agent2-key.pem');
|
|
const cert = fixtures.readKey('agent2-cert.pem');
|
|
|
|
// TODO(@sam-github) test works with TLS1.3, rework test to add
|
|
// 'ECDH' with 'TLS_AES_128_GCM_SHA256',
|
|
|
|
function loadDHParam(n) {
|
|
return fixtures.readKey(`dh${n}.pem`);
|
|
}
|
|
|
|
function test(size, type, name, cipher) {
|
|
assert(cipher);
|
|
|
|
const options = {
|
|
key: key,
|
|
cert: cert,
|
|
ciphers: cipher,
|
|
maxVersion: 'TLSv1.2',
|
|
};
|
|
|
|
if (name) options.ecdhCurve = name;
|
|
|
|
if (type === 'DH') options.dhparam = loadDHParam(size);
|
|
|
|
const server = tls.createServer(options, common.mustCall((conn) => {
|
|
assert.strictEqual(conn.getEphemeralKeyInfo(), null);
|
|
conn.end();
|
|
}));
|
|
|
|
server.on('close', common.mustSucceed());
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const client = tls.connect({
|
|
port: server.address().port,
|
|
rejectUnauthorized: false
|
|
}, common.mustCall(function() {
|
|
const ekeyinfo = client.getEphemeralKeyInfo();
|
|
assert.strictEqual(ekeyinfo.type, type);
|
|
assert.strictEqual(ekeyinfo.size, size);
|
|
assert.strictEqual(ekeyinfo.name, name);
|
|
server.close();
|
|
}));
|
|
client.on('secureConnect', common.mustCall());
|
|
}));
|
|
}
|
|
|
|
test(undefined, undefined, undefined, 'AES128-SHA256');
|
|
test(1024, 'DH', undefined, 'DHE-RSA-AES128-GCM-SHA256');
|
|
test(2048, 'DH', undefined, 'DHE-RSA-AES128-GCM-SHA256');
|
|
test(256, 'ECDH', 'prime256v1', 'ECDHE-RSA-AES128-GCM-SHA256');
|
|
test(521, 'ECDH', 'secp521r1', 'ECDHE-RSA-AES128-GCM-SHA256');
|
|
test(253, 'ECDH', 'X25519', 'ECDHE-RSA-AES128-GCM-SHA256');
|
|
test(448, 'ECDH', 'X448', 'ECDHE-RSA-AES128-GCM-SHA256');
|