node/test/parallel/test-http-parser-memory-retention.js
John Leidegren 26f150022f http: fixes memory retention issue with FreeList and HTTPParser
Fixes: https://github.com/nodejs/node/issues/29394
Refs: https://github.com/nodejs/node/pull/33167#issuecomment-622102450

PR-URL: https://github.com/nodejs/node/pull/33190
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
2020-05-05 16:14:46 +02:00

43 lines
1.1 KiB
JavaScript

'use strict';
const common = require('../common');
const assert = require('assert');
const http = require('http');
const { HTTPParser } = require('_http_common');
// Test that the `HTTPParser` instance is cleaned up before being returned to
// the pool to avoid memory retention issues.
const kOnTimeout = HTTPParser.kOnTimeout | 0;
const server = http.createServer();
server.on('request', common.mustCall((request, response) => {
const parser = request.socket.parser;
assert.strictEqual(typeof parser[kOnTimeout], 'function');
request.socket.on('close', common.mustCall(() => {
assert.strictEqual(parser[kOnTimeout], null);
}));
response.end();
server.close();
}));
server.listen(common.mustCall(() => {
const request = http.get({ port: server.address().port });
let parser;
request.on('socket', common.mustCall(() => {
parser = request.parser;
assert.strictEqual(typeof parser.onIncoming, 'function');
}));
request.on('response', common.mustCall((response) => {
response.resume();
response.on('end', common.mustCall(() => {
assert.strictEqual(parser.onIncoming, null);
}));
}));
}));