mirror of
https://github.com/nodejs/node.git
synced 2025-05-09 12:20:18 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
56 lines
1.6 KiB
JavaScript
56 lines
1.6 KiB
JavaScript
// Flags: --expose-internals
|
|
|
|
'use strict';
|
|
const { expectsError, mustCall } = require('../common');
|
|
const assert = require('assert');
|
|
const { createServer, maxHeaderSize } = require('http');
|
|
const { createConnection } = require('net');
|
|
|
|
const { getOptionValue } = require('internal/options');
|
|
|
|
const CRLF = '\r\n';
|
|
const DUMMY_HEADER_NAME = 'Cookie: ';
|
|
const DUMMY_HEADER_VALUE = 'a'.repeat(
|
|
// Plus one is to make it 1 byte too big
|
|
maxHeaderSize - DUMMY_HEADER_NAME.length - (2 * CRLF.length) + 1
|
|
);
|
|
const PAYLOAD_GET = 'GET /blah HTTP/1.1';
|
|
const PAYLOAD = PAYLOAD_GET + CRLF +
|
|
DUMMY_HEADER_NAME + DUMMY_HEADER_VALUE + CRLF.repeat(2);
|
|
|
|
const server = createServer();
|
|
|
|
server.on('connection', mustCall((socket) => {
|
|
// Legacy parser gives sligthly different response.
|
|
// This discripancy is not fixed on purpose.
|
|
const legacy = getOptionValue('--http-parser') === 'legacy';
|
|
socket.on('error', expectsError({
|
|
name: 'Error',
|
|
message: 'Parse Error: Header overflow',
|
|
code: 'HPE_HEADER_OVERFLOW',
|
|
bytesParsed: maxHeaderSize + PAYLOAD_GET.length - (legacy ? -1 : 0),
|
|
rawPacket: Buffer.from(PAYLOAD)
|
|
}));
|
|
}));
|
|
|
|
server.listen(0, mustCall(() => {
|
|
const c = createConnection(server.address().port);
|
|
let received = '';
|
|
|
|
c.on('connect', mustCall(() => {
|
|
c.write(PAYLOAD);
|
|
}));
|
|
c.on('data', mustCall((data) => {
|
|
received += data.toString();
|
|
}));
|
|
c.on('end', mustCall(() => {
|
|
assert.strictEqual(
|
|
received,
|
|
'HTTP/1.1 431 Request Header Fields Too Large\r\n' +
|
|
'Connection: close\r\n\r\n'
|
|
);
|
|
c.end();
|
|
}));
|
|
c.on('close', mustCall(() => server.close()));
|
|
}));
|