mirror of
https://github.com/nodejs/node.git
synced 2025-05-09 14:32:49 +00:00
8886b63cf6
This reverts c380ee6785.
uv_fs_write returns an int, so it is not possible to ask
it to write more than INT32_MAX.
Instead, validate 'length' is an int32 in JS to avoid
the assertion failure.
PR-URL: https://github.com/nodejs/node/pull/38546
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
41 lines
1014 B
JavaScript
41 lines
1014 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const path = require('path');
|
|
const fs = require('fs');
|
|
|
|
const tmpdir = require('../common/tmpdir');
|
|
tmpdir.refresh();
|
|
|
|
// fs.write with length > INT32_MAX
|
|
|
|
common.skipIf32Bits();
|
|
|
|
let buf;
|
|
try {
|
|
buf = Buffer.allocUnsafe(0x7FFFFFFF + 1);
|
|
} catch (e) {
|
|
// If the exception is not due to memory confinement then rethrow it.
|
|
if (e.message !== 'Array buffer allocation failed') throw (e);
|
|
common.skip('skipped due to memory requirements');
|
|
}
|
|
|
|
const filename = path.join(tmpdir.path, 'write9.txt');
|
|
fs.open(filename, 'w', 0o644, common.mustSucceed((fd) => {
|
|
assert.throws(() => {
|
|
fs.write(fd,
|
|
buf,
|
|
0,
|
|
0x7FFFFFFF + 1,
|
|
0,
|
|
common.mustNotCall());
|
|
}, {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError',
|
|
message: 'The value of "length" is out of range. ' +
|
|
'It must be >= 0 && <= 2147483647. Received 2147483648'
|
|
});
|
|
|
|
fs.closeSync(fd);
|
|
}));
|