mirror of
https://github.com/nodejs/node.git
synced 2025-04-30 15:41:06 +00:00
7d81f5d143
cp.exec decide to use `_stdout`(_stdout is string) or `Buffer.concat(_stdout)`(_stdout is buffer array) by options.encoding. but std(out|err) encoding can be changed. If encoding is changed to not null, `_stdout` will become string, and `Buffer.concat(_stdout)` will throw TypeError. This patch will fix it, use options.encoding and `std(out|err)._readableState.encoding`. PR-URL: https://github.com/nodejs/node/pull/18976 Fixes: https://github.com/nodejs/node/issues/18969 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
24 lines
751 B
JavaScript
24 lines
751 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const cp = require('child_process');
|
|
const stdoutData = 'foo';
|
|
const stderrData = 'bar';
|
|
const expectedStdout = `${stdoutData}\n`;
|
|
const expectedStderr = `${stderrData}\n`;
|
|
|
|
if (process.argv[2] === 'child') {
|
|
// The following console calls are part of the test.
|
|
console.log(stdoutData);
|
|
console.error(stderrData);
|
|
} else {
|
|
const cmd = `"${process.execPath}" "${__filename}" child`;
|
|
const child = cp.exec(cmd, common.mustCall((err, stdout, stderr) => {
|
|
assert.ifError(err);
|
|
assert.strictEqual(stdout, expectedStdout);
|
|
assert.strictEqual(stderr, expectedStderr);
|
|
}));
|
|
child.stdout.setEncoding('utf-8');
|
|
child.stderr.setEncoding('utf-8');
|
|
}
|