mirror of
https://github.com/nodejs/node.git
synced 2025-05-21 08:57:07 +00:00
7885b1d7aa
The role of `this.server` is now split between `this._server` and `this.server`. Where the first one is used for counting active connections of `net.Server`, and the latter one is just a public API for users' consumption. The reasoning for this is simple, `TLSSocket` instances wrap `net.Socket` instances, thus both refer to the `net.Server` through the `this.server` property. However, only one of them should be used for `net.Server` connection count book-keeping, otherwise double-decrement will happen on socket destruction. Fix: #5083 PR-URL: https://github.com/nodejs/node/pull/5262 Reviewed-By: James M Snell <jasnell@gmail.com>
54 lines
1.1 KiB
JavaScript
54 lines
1.1 KiB
JavaScript
'use strict';
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
|
|
var net = require('net');
|
|
|
|
var s = new net.Stream();
|
|
|
|
// test that destroy called on a stream with a server only ever decrements the
|
|
// server connection count once
|
|
|
|
s.server = new net.Server();
|
|
s.server.connections = 10;
|
|
s._server = s.server;
|
|
|
|
assert.equal(10, s.server.connections);
|
|
s.destroy();
|
|
assert.equal(9, s.server.connections);
|
|
s.destroy();
|
|
assert.equal(9, s.server.connections);
|
|
|
|
var SIZE = 2E6;
|
|
var N = 10;
|
|
var buf = new Buffer(SIZE);
|
|
buf.fill(0x61); // 'a'
|
|
|
|
var server = net.createServer(function(socket) {
|
|
socket.setNoDelay();
|
|
|
|
socket.on('error', function(err) {
|
|
socket.destroy();
|
|
}).on('close', function() {
|
|
server.close();
|
|
});
|
|
|
|
for (var i = 0; i < N; ++i) {
|
|
socket.write(buf, function() { });
|
|
}
|
|
socket.end();
|
|
|
|
}).listen(common.PORT, function() {
|
|
var conn = net.connect(common.PORT);
|
|
conn.on('data', function(buf) {
|
|
conn.pause();
|
|
setTimeout(function() {
|
|
conn.destroy();
|
|
}, 20);
|
|
});
|
|
});
|
|
|
|
process.on('exit', function() {
|
|
assert.equal(server.connections, 0);
|
|
});
|