mirror of
https://github.com/nodejs/node.git
synced 2025-05-10 19:17:56 +00:00
7778c035a0
Instead of putting the source code and the cache in v8::Objects,
put them in per-process std::maps. This has the following benefits:
- It's slightly lighter in weight compared to storing things on the
v8 heap. Also it may be slightly faster since the preivous v8::Object
is already in dictionary mode - though the difference is very small
given the number of native modules is limited.
- The source and code cache generation templates are now much simpler
since they just initialize static arrays and manipulate STL
constructs.
- The static native module data can be accessed independently of any
Environment or Isolate, and it's easy to look them up from the
C++'s side.
- It's now impossible to mutate the source code used to compile
native modules from the JS land since it's completely separate
from the v8 heap. We can still get the constant strings from
process.binding('natives') but that's all.
A few drive-by fixes:
- Remove DecorateErrorStack in LookupAndCompile - We don't need to
capture the exception to decorate when we encounter
errors during native module compilation, as those errors should be
syntax errors and v8 is able to decorate them well. We use
CompileFunctionInContext so there is no need to worry about
wrappers either.
- The code cache could be rejected when node is started with v8 flags.
Instead of aborting in that case, simply keep a record in the
native_module_without_cache set.
- Refactor js2c.py a bit, reduce code duplication and inline Render()
to make the one-byte/two-byte special treatment easier to read.
PR-URL: https://github.com/nodejs/node/pull/24384
Fixes: https://github.com/Remove
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
79 lines
2.4 KiB
JavaScript
79 lines
2.4 KiB
JavaScript
'use strict';
|
|
|
|
// This is only exposed for internal build steps and testing purposes.
|
|
// We create new copies of the source and the code cache
|
|
// so the resources eventually used to compile builtin modules
|
|
// cannot be tampered with even with --expose-internals
|
|
|
|
const {
|
|
NativeModule
|
|
} = require('internal/bootstrap/loaders');
|
|
const {
|
|
getSource,
|
|
compileCodeCache
|
|
} = internalBinding('native_module');
|
|
const { hasTracing } = process.binding('config');
|
|
|
|
const source = getSource();
|
|
const depsModule = Object.keys(source).filter(
|
|
(key) => NativeModule.isDepsModule(key) || key.startsWith('internal/deps')
|
|
);
|
|
|
|
// Modules with source code compiled in js2c that
|
|
// cannot be compiled with the code cache
|
|
const cannotUseCache = [
|
|
'config',
|
|
'sys', // deprecated
|
|
'internal/v8_prof_polyfill',
|
|
'internal/v8_prof_processor',
|
|
|
|
'internal/per_context',
|
|
|
|
'internal/test/binding',
|
|
// TODO(joyeecheung): update the C++ side so that
|
|
// the code cache is also used when compiling these
|
|
// two files.
|
|
'internal/bootstrap/loaders',
|
|
'internal/bootstrap/node'
|
|
].concat(depsModule);
|
|
|
|
// Skip modules that cannot be required when they are not
|
|
// built into the binary.
|
|
if (process.config.variables.v8_enable_inspector !== 1) {
|
|
cannotUseCache.push('inspector');
|
|
cannotUseCache.push('internal/util/inspector');
|
|
}
|
|
if (!hasTracing) {
|
|
cannotUseCache.push('trace_events');
|
|
}
|
|
if (!process.versions.openssl) {
|
|
cannotUseCache.push('crypto');
|
|
cannotUseCache.push('https');
|
|
cannotUseCache.push('http2');
|
|
cannotUseCache.push('tls');
|
|
cannotUseCache.push('_tls_common');
|
|
cannotUseCache.push('_tls_wrap');
|
|
cannotUseCache.push('internal/crypto/certificate');
|
|
cannotUseCache.push('internal/crypto/cipher');
|
|
cannotUseCache.push('internal/crypto/diffiehellman');
|
|
cannotUseCache.push('internal/crypto/hash');
|
|
cannotUseCache.push('internal/crypto/keygen');
|
|
cannotUseCache.push('internal/crypto/pbkdf2');
|
|
cannotUseCache.push('internal/crypto/random');
|
|
cannotUseCache.push('internal/crypto/scrypt');
|
|
cannotUseCache.push('internal/crypto/sig');
|
|
cannotUseCache.push('internal/crypto/util');
|
|
cannotUseCache.push('internal/http2/core');
|
|
cannotUseCache.push('internal/http2/compat');
|
|
cannotUseCache.push('internal/streams/lazy_transform');
|
|
}
|
|
|
|
module.exports = {
|
|
cachableBuiltins: Object.keys(source).filter(
|
|
(key) => !cannotUseCache.includes(key)
|
|
),
|
|
getSource(id) { return source[id]; },
|
|
getCodeCache: compileCodeCache,
|
|
cannotUseCache
|
|
};
|