mirror of
https://github.com/nodejs/node.git
synced 2025-05-11 01:27:14 +00:00
76340e3f10
* Remove needless RegExp flag In fixed case, `/g` flag is needless in the boolean context. * Remove needless RegExp capturing Use non-capturing grouping or remove capturing completely when: * capturing is useless per se, e.g. in test() check; * captured groups are not used afterward at all; * some of the later captured groups are not used afterward. * Use test, not match/exec in boolean context match() and exec() return a complicated object, unneeded in a boolean context. * Do not needlessly repeat RegExp creation This commit takes RegExp creation out of cycles and other repetitions. As long as the RegExp does not use /g flag and match indices, we are safe here. In tests, this fix hardly gives a significant performance gain, but it increases clarity and maintainability, reassuring some RegExps to be identical. RegExp in functions are not taken out of their functions: while these functions are called many times and their RegExps are recreated with each call, the performance gain in test cases does not seem to be worth decreasing function self-dependency. PR-URL: https://github.com/nodejs/node/pull/13770 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
64 lines
2.0 KiB
JavaScript
64 lines
2.0 KiB
JavaScript
'use strict';
|
|
// Flags: --expose_internals
|
|
|
|
const common = require('../common');
|
|
const path = require('path');
|
|
const assert = require('assert');
|
|
|
|
const binding = process.binding('util');
|
|
const kArrowMessagePrivateSymbolIndex = binding['arrow_message_private_symbol'];
|
|
|
|
function getHiddenValue(obj, index) {
|
|
return function() {
|
|
binding.getHiddenValue(obj, index);
|
|
};
|
|
}
|
|
|
|
function setHiddenValue(obj, index, val) {
|
|
return function() {
|
|
binding.setHiddenValue(obj, index, val);
|
|
};
|
|
}
|
|
|
|
const errMessageObj = /obj must be an object/;
|
|
const errMessageIndex = /index must be an uint32/;
|
|
|
|
assert.throws(getHiddenValue(), errMessageObj);
|
|
assert.throws(getHiddenValue(null, 'foo'), errMessageObj);
|
|
assert.throws(getHiddenValue(undefined, 'foo'), errMessageObj);
|
|
assert.throws(getHiddenValue('bar', 'foo'), errMessageObj);
|
|
assert.throws(getHiddenValue(85, 'foo'), errMessageObj);
|
|
assert.throws(getHiddenValue({}), errMessageIndex);
|
|
assert.throws(getHiddenValue({}, null), errMessageIndex);
|
|
assert.throws(getHiddenValue({}, []), errMessageIndex);
|
|
assert.deepStrictEqual(
|
|
binding.getHiddenValue({}, kArrowMessagePrivateSymbolIndex),
|
|
undefined);
|
|
|
|
assert.throws(setHiddenValue(), errMessageObj);
|
|
assert.throws(setHiddenValue(null, 'foo'), errMessageObj);
|
|
assert.throws(setHiddenValue(undefined, 'foo'), errMessageObj);
|
|
assert.throws(setHiddenValue('bar', 'foo'), errMessageObj);
|
|
assert.throws(setHiddenValue(85, 'foo'), errMessageObj);
|
|
assert.throws(setHiddenValue({}), errMessageIndex);
|
|
assert.throws(setHiddenValue({}, null), errMessageIndex);
|
|
assert.throws(setHiddenValue({}, []), errMessageIndex);
|
|
const obj = {};
|
|
assert.strictEqual(
|
|
binding.setHiddenValue(obj, kArrowMessagePrivateSymbolIndex, 'bar'),
|
|
true);
|
|
assert.strictEqual(
|
|
binding.getHiddenValue(obj, kArrowMessagePrivateSymbolIndex),
|
|
'bar');
|
|
|
|
let arrowMessage;
|
|
|
|
try {
|
|
require(path.join(common.fixturesDir, 'syntax', 'bad_syntax'));
|
|
} catch (err) {
|
|
arrowMessage =
|
|
binding.getHiddenValue(err, kArrowMessagePrivateSymbolIndex);
|
|
}
|
|
|
|
assert(/bad_syntax\.js:1/.test(arrowMessage));
|