mirror of
https://github.com/nodejs/node.git
synced 2025-05-21 10:42:18 +00:00
76340e3f10
* Remove needless RegExp flag In fixed case, `/g` flag is needless in the boolean context. * Remove needless RegExp capturing Use non-capturing grouping or remove capturing completely when: * capturing is useless per se, e.g. in test() check; * captured groups are not used afterward at all; * some of the later captured groups are not used afterward. * Use test, not match/exec in boolean context match() and exec() return a complicated object, unneeded in a boolean context. * Do not needlessly repeat RegExp creation This commit takes RegExp creation out of cycles and other repetitions. As long as the RegExp does not use /g flag and match indices, we are safe here. In tests, this fix hardly gives a significant performance gain, but it increases clarity and maintainability, reassuring some RegExps to be identical. RegExp in functions are not taken out of their functions: while these functions are called many times and their RegExps are recreated with each call, the performance gain in test cases does not seem to be worth decreasing function self-dependency. PR-URL: https://github.com/nodejs/node/pull/13770 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
74 lines
1.9 KiB
JavaScript
74 lines
1.9 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const { ChildProcess } = require('child_process');
|
|
assert.strictEqual(typeof ChildProcess, 'function');
|
|
|
|
{
|
|
// Verify that invalid options to spawn() throw.
|
|
const child = new ChildProcess();
|
|
const re = /^TypeError: "options" must be an object$/;
|
|
|
|
[undefined, null, 'foo', 0, 1, NaN, true, false].forEach((options) => {
|
|
assert.throws(() => {
|
|
child.spawn(options);
|
|
}, re);
|
|
});
|
|
}
|
|
|
|
{
|
|
// Verify that spawn throws if file is not a string.
|
|
const child = new ChildProcess();
|
|
const re = /^TypeError: "file" must be a string$/;
|
|
|
|
[undefined, null, 0, 1, NaN, true, false, {}].forEach((file) => {
|
|
assert.throws(() => {
|
|
child.spawn({ file });
|
|
}, re);
|
|
});
|
|
}
|
|
|
|
{
|
|
// Verify that spawn throws if envPairs is not an array or undefined.
|
|
const child = new ChildProcess();
|
|
const re = /^TypeError: "envPairs" must be an array$/;
|
|
|
|
[null, 0, 1, NaN, true, false, {}, 'foo'].forEach((envPairs) => {
|
|
assert.throws(() => {
|
|
child.spawn({ envPairs, stdio: ['ignore', 'ignore', 'ignore', 'ipc'] });
|
|
}, re);
|
|
});
|
|
}
|
|
|
|
{
|
|
// Verify that spawn throws if args is not an array or undefined.
|
|
const child = new ChildProcess();
|
|
const re = /^TypeError: "args" must be an array$/;
|
|
|
|
[null, 0, 1, NaN, true, false, {}, 'foo'].forEach((args) => {
|
|
assert.throws(() => {
|
|
child.spawn({ file: 'foo', args });
|
|
}, re);
|
|
});
|
|
}
|
|
|
|
// test that we can call spawn
|
|
const child = new ChildProcess();
|
|
child.spawn({
|
|
file: process.execPath,
|
|
args: ['--interactive'],
|
|
cwd: process.cwd(),
|
|
stdio: 'pipe'
|
|
});
|
|
|
|
assert.strictEqual(child.hasOwnProperty('pid'), true);
|
|
assert(Number.isInteger(child.pid));
|
|
|
|
// try killing with invalid signal
|
|
assert.throws(() => {
|
|
child.kill('foo');
|
|
}, common.expectsError({ code: 'ERR_UNKNOWN_SIGNAL' }));
|
|
|
|
assert.strictEqual(child.kill(), true);
|