mirror of
https://github.com/nodejs/node.git
synced 2025-05-08 14:36:08 +00:00

errorOrDestroy emits 'error' synchronously due to compat reasons. However, it should be possible to use correct async behaviour for new code. PR-URL: https://github.com/nodejs/node/pull/29744 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
57 lines
1.3 KiB
JavaScript
57 lines
1.3 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
|
|
const stream = require('stream');
|
|
|
|
class MyWritable extends stream.Writable {
|
|
constructor(options) {
|
|
super({ autoDestroy: false, ...options });
|
|
}
|
|
_write(chunk, encoding, callback) {
|
|
assert.notStrictEqual(chunk, null);
|
|
callback();
|
|
}
|
|
}
|
|
|
|
{
|
|
const m = new MyWritable({ objectMode: true });
|
|
m.write(null, (err) => assert.ok(err));
|
|
m.on('error', common.expectsError({
|
|
code: 'ERR_STREAM_NULL_VALUES',
|
|
name: 'TypeError',
|
|
message: 'May not write null values to stream'
|
|
}));
|
|
}
|
|
|
|
{ // Should not throw.
|
|
const m = new MyWritable({ objectMode: true }).on('error', assert);
|
|
m.write(null, assert);
|
|
}
|
|
|
|
{
|
|
const m = new MyWritable();
|
|
m.write(false, (err) => assert.ok(err));
|
|
m.on('error', common.expectsError({
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError'
|
|
}));
|
|
}
|
|
|
|
{ // Should not throw.
|
|
const m = new MyWritable().on('error', assert);
|
|
m.write(false, assert);
|
|
}
|
|
|
|
{ // Should not throw.
|
|
const m = new MyWritable({ objectMode: true });
|
|
m.write(false, assert.ifError);
|
|
}
|
|
|
|
{ // Should not throw.
|
|
const m = new MyWritable({ objectMode: true }).on('error', (e) => {
|
|
assert.ifError(e || new Error('should not get here'));
|
|
});
|
|
m.write(false, assert.ifError);
|
|
}
|