mirror of
https://github.com/nodejs/node.git
synced 2025-05-01 17:03:34 +00:00

Adds a new `../common/fixtures' module to begin normalizing `test/fixtures` use. Our test code is a bit inconsistent with regards to use of the fixtures directory. Some code uses `path.join()`, some code uses string concats, some other code uses template strings, etc. In mnay cases, significant duplication of code is seen when accessing fixture files, etc. This updates many (but by no means all) of the tests in the test suite to use the new consistent API. There are still many more to update, which would make an excelent Code-n-Learn exercise. PR-URL: https://github.com/nodejs/node/pull/14332 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
231 lines
8.2 KiB
JavaScript
231 lines
8.2 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
'use strict';
|
|
if (module.parent) {
|
|
// Signal we've been loaded as a module.
|
|
// The following console.log() is part of the test.
|
|
console.log('Loaded as a module, exiting with status code 42.');
|
|
process.exit(42);
|
|
}
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const child = require('child_process');
|
|
const path = require('path');
|
|
const fixtures = require('../common/fixtures');
|
|
const nodejs = `"${process.execPath}"`;
|
|
|
|
if (process.argv.length > 2) {
|
|
console.log(process.argv.slice(2).join(' '));
|
|
process.exit(0);
|
|
}
|
|
|
|
// Assert that nothing is written to stdout.
|
|
child.exec(`${nodejs} --eval 42`, common.mustCall((err, stdout, stderr) => {
|
|
assert.ifError(err);
|
|
assert.strictEqual(stdout, '');
|
|
assert.strictEqual(stderr, '');
|
|
}));
|
|
|
|
// Assert that "42\n" is written to stderr.
|
|
child.exec(`${nodejs} --eval "console.error(42)"`,
|
|
common.mustCall((err, stdout, stderr) => {
|
|
assert.ifError(err);
|
|
assert.strictEqual(stdout, '');
|
|
assert.strictEqual(stderr, '42\n');
|
|
}));
|
|
|
|
// Assert that the expected output is written to stdout.
|
|
['--print', '-p -e', '-pe', '-p'].forEach((s) => {
|
|
const cmd = `${nodejs} ${s} `;
|
|
|
|
child.exec(`${cmd}42`, common.mustCall((err, stdout, stderr) => {
|
|
assert.ifError(err);
|
|
assert.strictEqual(stdout, '42\n');
|
|
assert.strictEqual(stderr, '');
|
|
}));
|
|
|
|
child.exec(`${cmd} '[]'`, common.mustCall((err, stdout, stderr) => {
|
|
assert.ifError(err);
|
|
assert.strictEqual(stdout, '[]\n');
|
|
assert.strictEqual(stderr, '');
|
|
}));
|
|
});
|
|
|
|
// Assert that module loading works.
|
|
{
|
|
// Replace \ by / because Windows uses backslashes in paths, but they're still
|
|
// interpreted as the escape character when put between quotes.
|
|
const filename = __filename.replace(/\\/g, '/');
|
|
|
|
child.exec(`${nodejs} --eval "require('${filename}')"`,
|
|
common.mustCall((err, stdout, stderr) => {
|
|
assert.strictEqual(err.code, 42);
|
|
assert.strictEqual(
|
|
stdout, 'Loaded as a module, exiting with status code 42.\n');
|
|
assert.strictEqual(stderr, '');
|
|
}));
|
|
}
|
|
|
|
// Check that builtin modules are pre-defined.
|
|
child.exec(`${nodejs} --print "os.platform()"`,
|
|
common.mustCall((err, stdout, stderr) => {
|
|
assert.ifError(err);
|
|
assert.strictEqual(stderr, '');
|
|
assert.strictEqual(stdout.trim(), require('os').platform());
|
|
}));
|
|
|
|
// Module path resolve bug regression test.
|
|
const cwd = process.cwd();
|
|
process.chdir(path.resolve(__dirname, '../../'));
|
|
child.exec(`${nodejs} --eval "require('./test/parallel/test-cli-eval.js')"`,
|
|
common.mustCall((err, stdout, stderr) => {
|
|
assert.strictEqual(err.code, 42);
|
|
assert.strictEqual(
|
|
stdout, 'Loaded as a module, exiting with status code 42.\n');
|
|
assert.strictEqual(stderr, '');
|
|
}));
|
|
process.chdir(cwd);
|
|
|
|
// Missing argument should not crash.
|
|
child.exec(`${nodejs} -e`, common.mustCall((err, stdout, stderr) => {
|
|
assert.strictEqual(err.code, 9);
|
|
assert.strictEqual(stdout, '');
|
|
assert.strictEqual(stderr.trim(),
|
|
`${process.execPath}: -e requires an argument`);
|
|
}));
|
|
|
|
// Empty program should do nothing.
|
|
child.exec(`${nodejs} -e ""`, common.mustCall((err, stdout, stderr) => {
|
|
assert.ifError(err);
|
|
assert.strictEqual(stdout, '');
|
|
assert.strictEqual(stderr, '');
|
|
}));
|
|
|
|
// "\\-42" should be interpreted as an escaped expression, not a switch.
|
|
child.exec(`${nodejs} -p "\\-42"`, common.mustCall((err, stdout, stderr) => {
|
|
assert.ifError(err);
|
|
assert.strictEqual(stdout, '-42\n');
|
|
assert.strictEqual(stderr, '');
|
|
}));
|
|
|
|
child.exec(`${nodejs} --use-strict -p process.execArgv`,
|
|
common.mustCall((err, stdout, stderr) => {
|
|
assert.ifError(err);
|
|
assert.strictEqual(
|
|
stdout, "[ '--use-strict', '-p', 'process.execArgv' ]\n"
|
|
);
|
|
assert.strictEqual(stderr, '');
|
|
}));
|
|
|
|
// Regression test for https://github.com/nodejs/node/issues/3574.
|
|
{
|
|
const emptyFile = fixtures.path('empty.js');
|
|
|
|
child.exec(`${nodejs} -e 'require("child_process").fork("${emptyFile}")'`,
|
|
common.mustCall((err, stdout, stderr) => {
|
|
assert.ifError(err);
|
|
assert.strictEqual(stdout, '');
|
|
assert.strictEqual(stderr, '');
|
|
}));
|
|
|
|
// Make sure that monkey-patching process.execArgv doesn't cause child_process
|
|
// to incorrectly munge execArgv.
|
|
child.exec(
|
|
`${nodejs} -e "process.execArgv = ['-e', 'console.log(42)', 'thirdArg'];` +
|
|
`require('child_process').fork('${emptyFile}')"`,
|
|
common.mustCall((err, stdout, stderr) => {
|
|
assert.ifError(err);
|
|
assert.strictEqual(stdout, '42\n');
|
|
assert.strictEqual(stderr, '');
|
|
}));
|
|
}
|
|
|
|
// Regression test for https://github.com/nodejs/node/issues/8534.
|
|
{
|
|
const script = `
|
|
// console.log() can revive the event loop so we must be careful
|
|
// to write from a 'beforeExit' event listener only once.
|
|
process.once("beforeExit", () => console.log("beforeExit"));
|
|
process.on("exit", () => console.log("exit"));
|
|
console.log("start");
|
|
`;
|
|
const options = { encoding: 'utf8' };
|
|
const proc = child.spawnSync(process.execPath, ['-e', script], options);
|
|
assert.strictEqual(proc.stderr, '');
|
|
assert.strictEqual(proc.stdout, 'start\nbeforeExit\nexit\n');
|
|
}
|
|
|
|
// Regression test for https://github.com/nodejs/node/issues/11948.
|
|
{
|
|
const script = `
|
|
process.on('message', (message) => {
|
|
if (message === 'ping') process.send('pong');
|
|
if (message === 'exit') process.disconnect();
|
|
});
|
|
`;
|
|
const proc = child.fork('-e', [script]);
|
|
proc.on('exit', common.mustCall((exitCode, signalCode) => {
|
|
assert.strictEqual(exitCode, 0);
|
|
assert.strictEqual(signalCode, null);
|
|
}));
|
|
proc.on('message', (message) => {
|
|
if (message === 'pong') proc.send('exit');
|
|
});
|
|
proc.send('ping');
|
|
}
|
|
|
|
[ '-arg1',
|
|
'-arg1 arg2 --arg3',
|
|
'--',
|
|
'arg1 -- arg2',
|
|
].forEach(function(args) {
|
|
|
|
// Ensure that arguments are successfully passed to eval.
|
|
const opt = ' --eval "console.log(process.argv.slice(1).join(\' \'))"';
|
|
const cmd = `${nodejs}${opt} -- ${args}`;
|
|
child.exec(cmd, common.mustCall(function(err, stdout, stderr) {
|
|
assert.strictEqual(stdout, `${args}\n`);
|
|
assert.strictEqual(stderr, '');
|
|
assert.strictEqual(err, null);
|
|
}));
|
|
|
|
// Ensure that arguments are successfully passed to print.
|
|
const popt = ' --print "process.argv.slice(1).join(\' \')"';
|
|
const pcmd = `${nodejs}${popt} -- ${args}`;
|
|
child.exec(pcmd, common.mustCall(function(err, stdout, stderr) {
|
|
assert.strictEqual(stdout, `${args}\n`);
|
|
assert.strictEqual(stderr, '');
|
|
assert.strictEqual(err, null);
|
|
}));
|
|
|
|
// Ensure that arguments are successfully passed to a script.
|
|
// The first argument after '--' should be interpreted as a script
|
|
// filename.
|
|
const filecmd = `${nodejs} -- "${__filename}" ${args}`;
|
|
child.exec(filecmd, common.mustCall(function(err, stdout, stderr) {
|
|
assert.strictEqual(stdout, `${args}\n`);
|
|
assert.strictEqual(stderr, '');
|
|
assert.strictEqual(err, null);
|
|
}));
|
|
});
|