mirror of
https://github.com/nodejs/node.git
synced 2025-04-30 23:56:58 +00:00
70dcacd710
Using `assert.fail()` with more than one argument is not intuitive to use and has no benefit over using a message on its own. Therefore this introduces a runtime deprecation in case it is used in that way. PR-URL: https://github.com/nodejs/node/pull/18418 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
65 lines
1.6 KiB
JavaScript
65 lines
1.6 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
|
|
common.expectWarning(
|
|
'DeprecationWarning',
|
|
'assert.fail() with more than one argument is deprecated. ' +
|
|
'Please use assert.strictEqual() instead or only pass a message.'
|
|
);
|
|
|
|
// Two args only, operator defaults to '!='
|
|
assert.throws(() => {
|
|
assert.fail('first', 'second');
|
|
}, {
|
|
code: 'ERR_ASSERTION',
|
|
name: 'AssertionError [ERR_ASSERTION]',
|
|
message: '\'first\' != \'second\'',
|
|
operator: '!=',
|
|
actual: 'first',
|
|
expected: 'second'
|
|
});
|
|
|
|
// Three args
|
|
assert.throws(() => {
|
|
assert.fail('ignored', 'ignored', 'another custom message');
|
|
}, {
|
|
code: 'ERR_ASSERTION',
|
|
name: 'AssertionError [ERR_ASSERTION]',
|
|
message: 'another custom message',
|
|
operator: undefined,
|
|
actual: 'ignored',
|
|
expected: 'ignored'
|
|
});
|
|
|
|
// Three args with custom Error
|
|
assert.throws(() => {
|
|
assert.fail(typeof 1, 'object', new TypeError('another custom message'));
|
|
}, {
|
|
name: 'TypeError',
|
|
message: 'another custom message',
|
|
operator: undefined,
|
|
actual: undefined,
|
|
expected: undefined,
|
|
code: undefined
|
|
});
|
|
|
|
// No third arg (but a fourth arg)
|
|
assert.throws(() => {
|
|
assert.fail('first', 'second', undefined, 'operator');
|
|
}, {
|
|
code: 'ERR_ASSERTION',
|
|
name: 'AssertionError [ERR_ASSERTION]',
|
|
message: '\'first\' operator \'second\'',
|
|
operator: 'operator',
|
|
actual: 'first',
|
|
expected: 'second'
|
|
});
|
|
|
|
// The stackFrameFunction should exclude the foo frame
|
|
assert.throws(
|
|
function foo() { assert.fail('first', 'second', 'message', '!==', foo); },
|
|
(err) => !/^\s*at\sfoo\b/m.test(err.stack)
|
|
);
|