mirror of
https://github.com/nodejs/node.git
synced 2025-05-04 08:28:40 +00:00

In parallel/test-http2-client-upload, the `client.destroy()` call could terminate the connection before all data was sent over the wire successfully. Using `client.shutdown()` removes the flakiness. Also, listen on `req.on('finish')` rather than the file stream’s `end` event, since we’re not interested in when the source stream finishes, but rather when the HTTP/2 stream finishes. PR-URL: https://github.com/nodejs/node/pull/17361 Refs: https://github.com/nodejs/node/pull/17356 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
54 lines
1.3 KiB
JavaScript
54 lines
1.3 KiB
JavaScript
'use strict';
|
|
|
|
// Verifies that uploading data from a client works
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const http2 = require('http2');
|
|
const fs = require('fs');
|
|
const fixtures = require('../common/fixtures');
|
|
|
|
const loc = fixtures.path('person.jpg');
|
|
let fileData;
|
|
|
|
assert(fs.existsSync(loc));
|
|
|
|
fs.readFile(loc, common.mustCall((err, data) => {
|
|
assert.ifError(err);
|
|
fileData = data;
|
|
|
|
const server = http2.createServer();
|
|
|
|
server.on('stream', common.mustCall((stream) => {
|
|
let data = Buffer.alloc(0);
|
|
stream.on('data', (chunk) => data = Buffer.concat([data, chunk]));
|
|
stream.on('end', common.mustCall(() => {
|
|
assert.deepStrictEqual(data, fileData);
|
|
}));
|
|
stream.respond();
|
|
stream.end();
|
|
}));
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const client = http2.connect(`http://localhost:${server.address().port}`);
|
|
|
|
let remaining = 2;
|
|
function maybeClose() {
|
|
if (--remaining === 0) {
|
|
server.close();
|
|
client.shutdown();
|
|
}
|
|
}
|
|
|
|
const req = client.request({ ':method': 'POST' });
|
|
req.on('response', common.mustCall());
|
|
req.resume();
|
|
req.on('end', common.mustCall(maybeClose));
|
|
const str = fs.createReadStream(loc);
|
|
req.on('finish', common.mustCall(maybeClose));
|
|
str.pipe(req);
|
|
}));
|
|
}));
|