mirror of
https://github.com/nodejs/node.git
synced 2025-05-05 15:32:15 +00:00
04b4d15b39
Many of the tests use variables to track when callback functions are invoked or events are emitted. These variables are then asserted on process exit. This commit replaces this pattern in straightforward cases with common.mustCall(). This makes the tests easier to reason about, leads to a net reduction in lines of code, and uncovered a few bugs in tests. This commit also replaces some callbacks that should never be called with common.fail(). PR-URL: https://github.com/nodejs/node/pull/7753 Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
38 lines
1.0 KiB
JavaScript
38 lines
1.0 KiB
JavaScript
'use strict';
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
|
|
if (!common.hasCrypto) {
|
|
common.skip('missing crypto');
|
|
return;
|
|
}
|
|
var tls = require('tls');
|
|
|
|
var exec = require('child_process').exec;
|
|
var fs = require('fs');
|
|
|
|
var options = {
|
|
key: fs.readFileSync(common.fixturesDir + '/keys/agent2-key.pem'),
|
|
cert: fs.readFileSync(common.fixturesDir + '/keys/agent2-cert.pem'),
|
|
ciphers: 'ECDHE-RSA-RC4-SHA',
|
|
ecdhCurve: false
|
|
};
|
|
|
|
var server = tls.createServer(options, common.fail);
|
|
|
|
server.listen(0, '127.0.0.1', function() {
|
|
var cmd = '"' + common.opensslCli + '" s_client -cipher ' + options.ciphers +
|
|
` -connect 127.0.0.1:${this.address().port}`;
|
|
|
|
// for the performance and stability issue in s_client on Windows
|
|
if (common.isWindows)
|
|
cmd += ' -no_rand_screen';
|
|
|
|
exec(cmd, function(err, stdout, stderr) {
|
|
// Old versions of openssl will still exit with 0 so we
|
|
// can't just check if err is not null.
|
|
assert.notEqual(stderr.indexOf('handshake failure'), -1);
|
|
server.close();
|
|
});
|
|
});
|