mirror of
https://github.com/nodejs/node.git
synced 2025-05-05 15:32:15 +00:00
60dcd7323f
`convertNPNProtocols` and `convertALPNProtocols' uses the `protocols` buffer object as it is, and if it is modified outside of core, it might have an impact. This patch makes a copy of the buffer object, before using it. PR-URL: https://github.com/nodejs/node/pull/8055 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
59 lines
1.9 KiB
JavaScript
59 lines
1.9 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto) {
|
|
common.skip('missing crypto');
|
|
return;
|
|
}
|
|
|
|
const assert = require('assert');
|
|
const tls = require('tls');
|
|
|
|
assert.throws(() => tls.createSecureContext({ciphers: 1}),
|
|
/TypeError: Ciphers must be a string/);
|
|
|
|
assert.throws(() => tls.createServer({ciphers: 1}),
|
|
/TypeError: Ciphers must be a string/);
|
|
|
|
assert.throws(() => tls.createSecureContext({key: 'dummykey', passphrase: 1}),
|
|
/TypeError: Pass phrase must be a string/);
|
|
|
|
assert.throws(() => tls.createServer({key: 'dummykey', passphrase: 1}),
|
|
/TypeError: Pass phrase must be a string/);
|
|
|
|
assert.throws(() => tls.createServer({ecdhCurve: 1}),
|
|
/TypeError: ECDH curve name must be a string/);
|
|
|
|
assert.throws(() => tls.createServer({handshakeTimeout: 'abcd'}),
|
|
/TypeError: handshakeTimeout must be a number/);
|
|
|
|
assert.throws(() => tls.createServer({sessionTimeout: 'abcd'}),
|
|
/TypeError: Session timeout must be a 32-bit integer/);
|
|
|
|
assert.throws(() => tls.createServer({ticketKeys: 'abcd'}),
|
|
/TypeError: Ticket keys must be a buffer/);
|
|
|
|
assert.throws(() => tls.createServer({ticketKeys: new Buffer(0)}),
|
|
/TypeError: Ticket keys length must be 48 bytes/);
|
|
|
|
assert.throws(() => tls.createSecurePair({}),
|
|
/Error: First argument must be a tls module SecureContext/);
|
|
|
|
{
|
|
const buffer = Buffer.from('abcd');
|
|
const out = {};
|
|
tls.convertALPNProtocols(buffer, out);
|
|
out.ALPNProtocols.write('efgh');
|
|
assert(buffer.equals(Buffer.from('abcd')));
|
|
assert(out.ALPNProtocols.equals(Buffer.from('efgh')));
|
|
}
|
|
|
|
{
|
|
const buffer = Buffer.from('abcd');
|
|
const out = {};
|
|
tls.convertNPNProtocols(buffer, out);
|
|
out.NPNProtocols.write('efgh');
|
|
assert(buffer.equals(Buffer.from('abcd')));
|
|
assert(out.NPNProtocols.equals(Buffer.from('efgh')));
|
|
}
|