mirror of
https://github.com/nodejs/node.git
synced 2025-05-05 15:32:15 +00:00
04b4d15b39
Many of the tests use variables to track when callback functions are invoked or events are emitted. These variables are then asserted on process exit. This commit replaces this pattern in straightforward cases with common.mustCall(). This makes the tests easier to reason about, leads to a net reduction in lines of code, and uncovered a few bugs in tests. This commit also replaces some callbacks that should never be called with common.fail(). PR-URL: https://github.com/nodejs/node/pull/7753 Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
42 lines
845 B
JavaScript
42 lines
845 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
var assert = require('assert');
|
|
|
|
var Stream = require('stream');
|
|
var Readable = Stream.Readable;
|
|
|
|
var r = new Readable();
|
|
var N = 256;
|
|
var reads = 0;
|
|
r._read = function(n) {
|
|
return r.push(++reads === N ? null : Buffer.allocUnsafe(1));
|
|
};
|
|
|
|
r.on('end', common.mustCall(function() {}));
|
|
|
|
var w = new Stream();
|
|
w.writable = true;
|
|
var buffered = 0;
|
|
w.write = function(c) {
|
|
buffered += c.length;
|
|
process.nextTick(drain);
|
|
return false;
|
|
};
|
|
|
|
function drain() {
|
|
assert(buffered <= 3);
|
|
buffered = 0;
|
|
w.emit('drain');
|
|
}
|
|
|
|
w.end = common.mustCall(function() {});
|
|
|
|
// Just for kicks, let's mess with the drain count.
|
|
// This verifies that even if it gets negative in the
|
|
// pipe() cleanup function, we'll still function properly.
|
|
r.on('readable', function() {
|
|
w.emit('drain');
|
|
});
|
|
|
|
r.pipe(w);
|