mirror of
https://github.com/nodejs/node.git
synced 2025-05-06 02:59:40 +00:00
45a716c968
test-stream2-readable-empty-buffer-no-eof fails on resource-constrained machines due to its use of timers. Removing timers makes it more reliable and doesn’t affect the validity of the test, as it only uses relative timing relations. Failures were noticed on freebsd10-64 in CI. I am able to replicate the failure with `tools/test.py --repeat=100 -j 100`. When run alone, it passes reliably. Refs: https://github.com/nodejs/node/pull/9359 PR-URL: hkttps://github.com/nodejs/node/pull/9360 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
98 lines
2.3 KiB
JavaScript
98 lines
2.3 KiB
JavaScript
'use strict';
|
|
require('../common');
|
|
const assert = require('assert');
|
|
|
|
const Readable = require('stream').Readable;
|
|
|
|
test1();
|
|
test2();
|
|
|
|
function test1() {
|
|
const r = new Readable();
|
|
|
|
// should not end when we get a Buffer.alloc(0) or '' as the _read
|
|
// result that just means that there is *temporarily* no data, but to
|
|
// go ahead and try again later.
|
|
//
|
|
// note that this is very unusual. it only works for crypto streams
|
|
// because the other side of the stream will call read(0) to cycle
|
|
// data through openssl. that's why setImmediate() is used to call
|
|
// r.read(0) again later, otherwise there is no more work being done
|
|
// and the process just exits.
|
|
|
|
const buf = Buffer.alloc(5, 'x');
|
|
let reads = 5;
|
|
r._read = function(n) {
|
|
switch (reads--) {
|
|
case 5:
|
|
return setImmediate(function() {
|
|
return r.push(buf);
|
|
});
|
|
case 4:
|
|
setImmediate(function() {
|
|
return r.push(Buffer.alloc(0));
|
|
});
|
|
return setImmediate(r.read.bind(r, 0));
|
|
case 3:
|
|
setImmediate(r.read.bind(r, 0));
|
|
return process.nextTick(function() {
|
|
return r.push(Buffer.alloc(0));
|
|
});
|
|
case 2:
|
|
setImmediate(r.read.bind(r, 0));
|
|
return r.push(Buffer.alloc(0)); // Not-EOF!
|
|
case 1:
|
|
return r.push(buf);
|
|
case 0:
|
|
return r.push(null); // EOF
|
|
default:
|
|
throw new Error('unreachable');
|
|
}
|
|
};
|
|
|
|
const results = [];
|
|
function flow() {
|
|
let chunk;
|
|
while (null !== (chunk = r.read()))
|
|
results.push(chunk + '');
|
|
}
|
|
r.on('readable', flow);
|
|
r.on('end', function() {
|
|
results.push('EOF');
|
|
});
|
|
flow();
|
|
|
|
process.on('exit', function() {
|
|
assert.deepStrictEqual(results, [ 'xxxxx', 'xxxxx', 'EOF' ]);
|
|
console.log('ok');
|
|
});
|
|
}
|
|
|
|
function test2() {
|
|
var r = new Readable({ encoding: 'base64' });
|
|
var reads = 5;
|
|
r._read = function(n) {
|
|
if (!reads--)
|
|
return r.push(null); // EOF
|
|
else
|
|
return r.push(Buffer.from('x'));
|
|
};
|
|
|
|
var results = [];
|
|
function flow() {
|
|
var chunk;
|
|
while (null !== (chunk = r.read()))
|
|
results.push(chunk + '');
|
|
}
|
|
r.on('readable', flow);
|
|
r.on('end', function() {
|
|
results.push('EOF');
|
|
});
|
|
flow();
|
|
|
|
process.on('exit', function() {
|
|
assert.deepStrictEqual(results, [ 'eHh4', 'eHg=', 'EOF' ]);
|
|
console.log('ok');
|
|
});
|
|
}
|