mirror of
https://github.com/nodejs/node.git
synced 2025-05-05 15:32:15 +00:00
92212014ff
Before this commit, it was possible to push a partial character to a readable stream where it was decoded as an empty string and then added to the internal buffer. This caused the stream to not emit any data, even when the rest of the character bytes were pushed separately, because of a non-zero length check of the first chunk in the internal buffer. Fixes: https://github.com/nodejs/node/issues/5223 PR-URL: https://github.com/nodejs/node/pull/5226 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
24 lines
565 B
JavaScript
24 lines
565 B
JavaScript
'use strict';
|
|
require('../common');
|
|
const Readable = require('_stream_readable');
|
|
const assert = require('assert');
|
|
|
|
var buf = '';
|
|
const euro = new Buffer([0xE2, 0x82, 0xAC]);
|
|
const cent = new Buffer([0xC2, 0xA2]);
|
|
const source = Buffer.concat([euro, cent]);
|
|
|
|
const readable = Readable({ encoding: 'utf8' });
|
|
readable.push(source.slice(0, 2));
|
|
readable.push(source.slice(2, 4));
|
|
readable.push(source.slice(4, 6));
|
|
readable.push(null);
|
|
|
|
readable.on('data', function(data) {
|
|
buf += data;
|
|
});
|
|
|
|
process.on('exit', function() {
|
|
assert.strictEqual(buf, '€¢');
|
|
});
|