mirror of
https://github.com/nodejs/node.git
synced 2025-05-05 15:32:15 +00:00
76007079ec
This reverts commit fce4b981ea.
This was a breaking change and should have been marked semver-major.
The change that was made altered the output of util.format() and
util.inspect(). With how much those are used in the wild, this type of
change deserves more justification.
Fixes: https://github.com/nodejs/node/issues/8138
PR-URL: https://github.com/nodejs/node/pull/8143
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
50 lines
1.1 KiB
JavaScript
50 lines
1.1 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
var assert = require('assert');
|
|
var util = require('util');
|
|
var repl = require('repl');
|
|
|
|
// This test adds global variables
|
|
common.globalCheck = false;
|
|
|
|
const putIn = new common.ArrayStream();
|
|
repl.start('', putIn, null, true);
|
|
|
|
test1();
|
|
|
|
function test1() {
|
|
var gotWrite = false;
|
|
putIn.write = function(data) {
|
|
gotWrite = true;
|
|
if (data.length) {
|
|
|
|
// inspect output matches repl output
|
|
assert.equal(data, util.inspect(require('fs'), null, 2, false) + '\n');
|
|
// globally added lib matches required lib
|
|
assert.equal(global.fs, require('fs'));
|
|
test2();
|
|
}
|
|
};
|
|
assert(!gotWrite);
|
|
putIn.run(['fs']);
|
|
assert(gotWrite);
|
|
}
|
|
|
|
function test2() {
|
|
var gotWrite = false;
|
|
putIn.write = function(data) {
|
|
gotWrite = true;
|
|
if (data.length) {
|
|
// repl response error message
|
|
assert.equal(data, '{}\n');
|
|
// original value wasn't overwritten
|
|
assert.equal(val, global.url);
|
|
}
|
|
};
|
|
var val = {};
|
|
global.url = val;
|
|
assert(!gotWrite);
|
|
putIn.run(['url']);
|
|
assert(gotWrite);
|
|
}
|