mirror of
https://github.com/nodejs/node.git
synced 2025-05-05 15:32:15 +00:00
04b4d15b39
Many of the tests use variables to track when callback functions are invoked or events are emitted. These variables are then asserted on process exit. This commit replaces this pattern in straightforward cases with common.mustCall(). This makes the tests easier to reason about, leads to a net reduction in lines of code, and uncovered a few bugs in tests. This commit also replaces some callbacks that should never be called with common.fail(). PR-URL: https://github.com/nodejs/node/pull/7753 Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
38 lines
1.0 KiB
JavaScript
38 lines
1.0 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const spawn = require('child_process').spawn;
|
|
|
|
if (common.isWindows) {
|
|
common.skip('Win32 doesn\'t have signals, just a kind of ' +
|
|
'emulation, insufficient for this test to apply.');
|
|
return;
|
|
}
|
|
|
|
if (process.argv[2] !== '--do-test') {
|
|
// We are the master, fork a child so we can verify it exits with correct
|
|
// status.
|
|
process.env.DOTEST = 'y';
|
|
var child = spawn(process.execPath, [__filename, '--do-test']);
|
|
|
|
child.once('exit', common.mustCall(function(code, signal) {
|
|
assert.equal(signal, 'SIGINT');
|
|
}));
|
|
|
|
return;
|
|
}
|
|
|
|
process.on('SIGINT', function() {
|
|
// Remove all handlers and kill ourselves. We should terminate by SIGINT
|
|
// now that we have no handlers.
|
|
process.removeAllListeners('SIGINT');
|
|
process.kill(process.pid, 'SIGINT');
|
|
});
|
|
|
|
// Signal handlers aren't sufficient to keep node alive, so resume stdin
|
|
process.stdin.resume();
|
|
|
|
// Demonstrate that signals are being handled
|
|
process.kill(process.pid, 'SIGINT');
|