mirror of
https://github.com/nodejs/node.git
synced 2025-05-05 15:32:15 +00:00

Many of the tests use variables to track when callback functions are invoked or events are emitted. These variables are then asserted on process exit. This commit replaces this pattern in straightforward cases with common.mustCall(). This makes the tests easier to reason about, leads to a net reduction in lines of code, and uncovered a few bugs in tests. This commit also replaces some callbacks that should never be called with common.fail(). PR-URL: https://github.com/nodejs/node/pull/7753 Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
171 lines
4.3 KiB
JavaScript
171 lines
4.3 KiB
JavaScript
'use strict';
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
|
|
if (!common.hasCrypto) {
|
|
common.skip('missing crypto');
|
|
return;
|
|
}
|
|
var https = require('https');
|
|
|
|
var tls = require('tls');
|
|
var fs = require('fs');
|
|
|
|
var tests = [];
|
|
|
|
var serverOptions = {
|
|
key: fs.readFileSync(common.fixturesDir + '/keys/agent1-key.pem'),
|
|
cert: fs.readFileSync(common.fixturesDir + '/keys/agent1-cert.pem')
|
|
};
|
|
|
|
function test(fn) {
|
|
if (!tests.length)
|
|
process.nextTick(run);
|
|
tests.push(fn);
|
|
}
|
|
|
|
function run() {
|
|
var fn = tests.shift();
|
|
if (fn) {
|
|
console.log('# %s', fn.name);
|
|
fn(run);
|
|
} else {
|
|
console.log('ok');
|
|
}
|
|
}
|
|
|
|
test(function serverTimeout(cb) {
|
|
var server = https.createServer(serverOptions, function(req, res) {
|
|
// just do nothing, we should get a timeout event.
|
|
});
|
|
server.listen(0, common.mustCall(function() {
|
|
var s = server.setTimeout(50, common.mustCall(function(socket) {
|
|
socket.destroy();
|
|
server.close();
|
|
cb();
|
|
}));
|
|
assert.ok(s instanceof https.Server);
|
|
https.get({
|
|
port: this.address().port,
|
|
rejectUnauthorized: false
|
|
}).on('error', function() {});
|
|
}));
|
|
});
|
|
|
|
test(function serverRequestTimeout(cb) {
|
|
function handler(req, res) {
|
|
// just do nothing, we should get a timeout event.
|
|
req.setTimeout(50, common.mustCall(function() {
|
|
req.socket.destroy();
|
|
server.close();
|
|
cb();
|
|
}));
|
|
}
|
|
|
|
var server = https.createServer(serverOptions, common.mustCall(handler));
|
|
server.listen(0, function() {
|
|
var req = https.request({
|
|
port: this.address().port,
|
|
method: 'POST',
|
|
rejectUnauthorized: false
|
|
});
|
|
req.on('error', function() {});
|
|
req.write('Hello');
|
|
// req is in progress
|
|
});
|
|
});
|
|
|
|
test(function serverResponseTimeout(cb) {
|
|
function handler(req, res) {
|
|
// just do nothing, we should get a timeout event.
|
|
res.setTimeout(50, common.mustCall(function() {
|
|
res.socket.destroy();
|
|
server.close();
|
|
cb();
|
|
}));
|
|
}
|
|
|
|
var server = https.createServer(serverOptions, common.mustCall(handler));
|
|
server.listen(0, function() {
|
|
https.get({
|
|
port: this.address().port,
|
|
rejectUnauthorized: false
|
|
}).on('error', function() {});
|
|
});
|
|
});
|
|
|
|
test(function serverRequestNotTimeoutAfterEnd(cb) {
|
|
function handler(req, res) {
|
|
// just do nothing, we should get a timeout event.
|
|
req.setTimeout(50, common.fail);
|
|
res.on('timeout', common.mustCall(function(socket) {}));
|
|
}
|
|
var server = https.createServer(serverOptions, common.mustCall(handler));
|
|
server.on('timeout', function(socket) {
|
|
socket.destroy();
|
|
server.close();
|
|
cb();
|
|
});
|
|
server.listen(0, function() {
|
|
https.get({
|
|
port: this.address().port,
|
|
rejectUnauthorized: false
|
|
}).on('error', function() {});
|
|
});
|
|
});
|
|
|
|
test(function serverResponseTimeoutWithPipeline(cb) {
|
|
var caughtTimeout = '';
|
|
process.on('exit', function() {
|
|
assert.equal(caughtTimeout, '/2');
|
|
});
|
|
var server = https.createServer(serverOptions, function(req, res) {
|
|
res.setTimeout(50, function() {
|
|
caughtTimeout += req.url;
|
|
});
|
|
if (req.url === '/1') res.end();
|
|
});
|
|
server.on('timeout', function(socket) {
|
|
socket.destroy();
|
|
server.close();
|
|
cb();
|
|
});
|
|
server.listen(0, function() {
|
|
var options = {
|
|
port: this.address().port,
|
|
allowHalfOpen: true,
|
|
rejectUnauthorized: false
|
|
};
|
|
var c = tls.connect(options, function() {
|
|
c.write('GET /1 HTTP/1.1\r\nHost: localhost\r\n\r\n');
|
|
c.write('GET /2 HTTP/1.1\r\nHost: localhost\r\n\r\n');
|
|
c.write('GET /3 HTTP/1.1\r\nHost: localhost\r\n\r\n');
|
|
});
|
|
});
|
|
});
|
|
|
|
test(function idleTimeout(cb) {
|
|
var server = https.createServer(serverOptions,
|
|
common.mustCall(function(req, res) {
|
|
req.on('timeout', common.fail);
|
|
res.on('timeout', common.fail);
|
|
res.end();
|
|
}));
|
|
server.setTimeout(50, common.mustCall(function(socket) {
|
|
socket.destroy();
|
|
server.close();
|
|
cb();
|
|
}));
|
|
server.listen(0, function() {
|
|
var options = {
|
|
port: this.address().port,
|
|
allowHalfOpen: true,
|
|
rejectUnauthorized: false
|
|
};
|
|
tls.connect(options, function() {
|
|
this.write('GET /1 HTTP/1.1\r\nHost: localhost\r\n\r\n');
|
|
// Keep-Alive
|
|
});
|
|
});
|
|
});
|