mirror of
https://github.com/nodejs/node.git
synced 2025-05-05 15:32:15 +00:00
04b4d15b39
Many of the tests use variables to track when callback functions are invoked or events are emitted. These variables are then asserted on process exit. This commit replaces this pattern in straightforward cases with common.mustCall(). This makes the tests easier to reason about, leads to a net reduction in lines of code, and uncovered a few bugs in tests. This commit also replaces some callbacks that should never be called with common.fail(). PR-URL: https://github.com/nodejs/node/pull/7753 Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
87 lines
1.9 KiB
JavaScript
87 lines
1.9 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
|
|
if (!common.hasCrypto) {
|
|
common.skip('missing crypto');
|
|
return;
|
|
}
|
|
|
|
const assert = require('assert');
|
|
const https = require('https');
|
|
const fs = require('fs');
|
|
const SSL_OP_NO_TICKET = require('crypto').constants.SSL_OP_NO_TICKET;
|
|
|
|
const options = {
|
|
key: fs.readFileSync(common.fixturesDir + '/keys/agent1-key.pem'),
|
|
cert: fs.readFileSync(common.fixturesDir + '/keys/agent1-cert.pem'),
|
|
secureOptions: SSL_OP_NO_TICKET
|
|
};
|
|
|
|
// Create TLS1.2 server
|
|
https.createServer(options, function(req, res) {
|
|
res.end('ohai');
|
|
}).listen(0, function() {
|
|
first(this);
|
|
});
|
|
|
|
// Do request and let agent cache the session
|
|
function first(server) {
|
|
const port = server.address().port;
|
|
const req = https.request({
|
|
port: port,
|
|
rejectUnauthorized: false
|
|
}, function(res) {
|
|
res.resume();
|
|
|
|
server.close(function() {
|
|
faultyServer(port);
|
|
});
|
|
});
|
|
req.end();
|
|
}
|
|
|
|
// Create TLS1 server
|
|
function faultyServer(port) {
|
|
options.secureProtocol = 'TLSv1_method';
|
|
https.createServer(options, function(req, res) {
|
|
res.end('hello faulty');
|
|
}).listen(port, function() {
|
|
second(this);
|
|
});
|
|
}
|
|
|
|
// Attempt to request using cached session
|
|
function second(server, session) {
|
|
const req = https.request({
|
|
port: server.address().port,
|
|
rejectUnauthorized: false
|
|
}, function(res) {
|
|
res.resume();
|
|
});
|
|
|
|
// Let it fail
|
|
req.on('error', common.mustCall(function(err) {
|
|
assert(/wrong version number/.test(err.message));
|
|
|
|
req.on('close', function() {
|
|
third(server);
|
|
});
|
|
}));
|
|
req.end();
|
|
}
|
|
|
|
// Try one more time - session should be evicted!
|
|
function third(server) {
|
|
const req = https.request({
|
|
port: server.address().port,
|
|
rejectUnauthorized: false
|
|
}, function(res) {
|
|
res.resume();
|
|
assert(!req.socket.isSessionReused());
|
|
server.close();
|
|
});
|
|
req.on('error', common.fail);
|
|
req.end();
|
|
}
|