mirror of
https://github.com/nodejs/node.git
synced 2025-05-05 19:08:17 +00:00
04b4d15b39
Many of the tests use variables to track when callback functions are invoked or events are emitted. These variables are then asserted on process exit. This commit replaces this pattern in straightforward cases with common.mustCall(). This makes the tests easier to reason about, leads to a net reduction in lines of code, and uncovered a few bugs in tests. This commit also replaces some callbacks that should never be called with common.fail(). PR-URL: https://github.com/nodejs/node/pull/7753 Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
61 lines
1.6 KiB
JavaScript
61 lines
1.6 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
var assert = require('assert');
|
|
var http = require('http');
|
|
var net = require('net');
|
|
|
|
// If an HTTP server is broken and sends data after the end of the response,
|
|
// node should ignore it and drop the connection.
|
|
// Demos this bug: https://github.com/joyent/node/issues/680
|
|
|
|
var body = 'hello world\r\n';
|
|
var fullResponse =
|
|
'HTTP/1.1 500 Internal Server Error\r\n' +
|
|
'Content-Length: ' + body.length + '\r\n' +
|
|
'Content-Type: text/plain\r\n' +
|
|
'Date: Fri + 18 Feb 2011 06:22:45 GMT\r\n' +
|
|
'Host: 10.20.149.2\r\n' +
|
|
'Access-Control-Allow-Credentials: true\r\n' +
|
|
'Server: badly broken/0.1 (OS NAME)\r\n' +
|
|
'\r\n' +
|
|
body;
|
|
|
|
var server = net.createServer(function(socket) {
|
|
var postBody = '';
|
|
|
|
socket.setEncoding('utf8');
|
|
|
|
socket.on('data', function(chunk) {
|
|
postBody += chunk;
|
|
|
|
if (postBody.indexOf('\r\n') > -1) {
|
|
socket.write(fullResponse);
|
|
// omg, I wrote the response twice, what a terrible HTTP server I am.
|
|
socket.end(fullResponse);
|
|
}
|
|
});
|
|
|
|
socket.on('error', function(err) {
|
|
assert.equal(err.code, 'ECONNRESET');
|
|
});
|
|
});
|
|
|
|
|
|
server.listen(0, common.mustCall(function() {
|
|
http.get({ port: this.address().port }, common.mustCall(function(res) {
|
|
var buffer = '';
|
|
console.log('Got res code: ' + res.statusCode);
|
|
|
|
res.setEncoding('utf8');
|
|
res.on('data', function(chunk) {
|
|
buffer += chunk;
|
|
});
|
|
|
|
res.on('end', common.mustCall(function() {
|
|
console.log('Response ended, read ' + buffer.length + ' bytes');
|
|
assert.equal(body, buffer);
|
|
server.close();
|
|
}));
|
|
}));
|
|
}));
|