mirror of
https://github.com/nodejs/node.git
synced 2025-05-05 15:32:15 +00:00
04b4d15b39
Many of the tests use variables to track when callback functions are invoked or events are emitted. These variables are then asserted on process exit. This commit replaces this pattern in straightforward cases with common.mustCall(). This makes the tests easier to reason about, leads to a net reduction in lines of code, and uncovered a few bugs in tests. This commit also replaces some callbacks that should never be called with common.fail(). PR-URL: https://github.com/nodejs/node/pull/7753 Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
64 lines
1.9 KiB
JavaScript
64 lines
1.9 KiB
JavaScript
'use strict';
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
var exec = require('child_process').exec;
|
|
var path = require('path');
|
|
|
|
function errExec(script, callback) {
|
|
var cmd = '"' + process.argv[0] + '" "' +
|
|
path.join(common.fixturesDir, script) + '"';
|
|
return exec(cmd, function(err, stdout, stderr) {
|
|
// There was some error
|
|
assert.ok(err);
|
|
|
|
// More than one line of error output.
|
|
assert.ok(stderr.split('\n').length > 2);
|
|
|
|
// Assert the script is mentioned in error output.
|
|
assert.ok(stderr.indexOf(script) >= 0);
|
|
|
|
// Proxy the args for more tests.
|
|
callback(err, stdout, stderr);
|
|
});
|
|
}
|
|
|
|
|
|
// Simple throw error
|
|
errExec('throws_error.js', common.mustCall(function(err, stdout, stderr) {
|
|
assert.ok(/blah/.test(stderr));
|
|
}));
|
|
|
|
|
|
// Trying to JSON.parse(undefined)
|
|
errExec('throws_error2.js', common.mustCall(function(err, stdout, stderr) {
|
|
assert.ok(/SyntaxError/.test(stderr));
|
|
}));
|
|
|
|
|
|
// Trying to JSON.parse(undefined) in nextTick
|
|
errExec('throws_error3.js', common.mustCall(function(err, stdout, stderr) {
|
|
assert.ok(/SyntaxError/.test(stderr));
|
|
}));
|
|
|
|
|
|
// throw ILLEGAL error
|
|
errExec('throws_error4.js', common.mustCall(function(err, stdout, stderr) {
|
|
assert.ok(/\/\*\*/.test(stderr));
|
|
assert.ok(/SyntaxError/.test(stderr));
|
|
}));
|
|
|
|
// Specific long exception line doesn't result in stack overflow
|
|
errExec('throws_error5.js', common.mustCall(function(err, stdout, stderr) {
|
|
assert.ok(/SyntaxError/.test(stderr));
|
|
}));
|
|
|
|
// Long exception line with length > errorBuffer doesn't result in assertion
|
|
errExec('throws_error6.js', common.mustCall(function(err, stdout, stderr) {
|
|
assert.ok(/SyntaxError/.test(stderr));
|
|
}));
|
|
|
|
// Object that throws in toString() doesn't print garbage
|
|
errExec('throws_error7.js', common.mustCall(function(err, stdout, stderr) {
|
|
assert.ok(/<toString\(\) threw exception/.test(stderr));
|
|
}));
|