mirror of
https://github.com/nodejs/node.git
synced 2025-05-05 15:32:15 +00:00
8e7cbe2546
Commit 2272052 ("net: bind to `::` TCP address by default") from
April 2014 seems to have accidentally changed the default listen
address from 127.0.0.1 to 0.0.0.0, a.k.a. the "any" address.
From a security viewpoint it's undesirable to accept debug agent
connections from anywhere so let's change that back. Users can
override the default with the `--debug=<host>:<port>` switch.
Fixes: https://github.com/nodejs/node/issues/8081
PR-URL: https://github.com/nodejs/node/pull/8106
Reviewed-By: James M Snell <jasnell@gmail.com>
49 lines
1.2 KiB
JavaScript
49 lines
1.2 KiB
JavaScript
'use strict';
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
var spawn = require('child_process').spawn;
|
|
|
|
var debugPort = common.PORT;
|
|
var args = ['--interactive', '--debug-port=' + debugPort];
|
|
var childOptions = { stdio: ['pipe', 'pipe', 'pipe', 'ipc'] };
|
|
var child = spawn(process.execPath, args, childOptions);
|
|
|
|
child.stdin.write("process.send({ msg: 'childready' });\n");
|
|
|
|
child.stderr.on('data', function(data) {
|
|
var lines = data.toString().replace(/\r/g, '').trim().split('\n');
|
|
lines.forEach(processStderrLine);
|
|
});
|
|
|
|
child.on('message', function onChildMsg(message) {
|
|
if (message.msg === 'childready') {
|
|
process._debugProcess(child.pid);
|
|
}
|
|
});
|
|
|
|
process.on('exit', function() {
|
|
child.kill();
|
|
assertOutputLines();
|
|
});
|
|
|
|
var outputLines = [];
|
|
function processStderrLine(line) {
|
|
console.log('> ' + line);
|
|
outputLines.push(line);
|
|
|
|
if (/Debugger listening/.test(line)) {
|
|
process.exit();
|
|
}
|
|
}
|
|
|
|
function assertOutputLines() {
|
|
var expectedLines = [
|
|
'Starting debugger agent.',
|
|
'Debugger listening on 127.0.0.1:' + debugPort,
|
|
];
|
|
|
|
assert.equal(outputLines.length, expectedLines.length);
|
|
for (var i = 0; i < expectedLines.length; i++)
|
|
assert(expectedLines[i].includes(outputLines[i]));
|
|
}
|