mirror of
https://github.com/nodejs/node.git
synced 2025-05-05 15:32:15 +00:00

A previous fix for a `maxBuffer` bug resulted in a change to the argument type for the `data` event on `child.stdin` and `child.stdout` when using `child_process.exec()`. This fixes the `maxBuffer` bug in a way that does not have that side effect. PR-URL: https://github.com/nodejs/node/pull/7391 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jackson Tian <shyvo1987@gmail.com> Fixes: https://github.com/nodejs/node/issues/7342 Refs: https://github.com/nodejs/node/issues/1901
32 lines
735 B
JavaScript
32 lines
735 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const cp = require('child_process');
|
|
|
|
function checkFactory(streamName) {
|
|
return common.mustCall((err) => {
|
|
const message = `${streamName} maxBuffer exceeded`;
|
|
assert.strictEqual(err.message, message);
|
|
});
|
|
}
|
|
|
|
{
|
|
const cmd = 'echo "hello world"';
|
|
|
|
cp.exec(cmd, { maxBuffer: 5 }, checkFactory('stdout'));
|
|
}
|
|
|
|
const unicode = '中文测试'; // length = 4, byte length = 12
|
|
|
|
{
|
|
const cmd = `"${process.execPath}" -e "console.log('${unicode}');"`;
|
|
|
|
cp.exec(cmd, {maxBuffer: 10}, checkFactory('stdout'));
|
|
}
|
|
|
|
{
|
|
const cmd = `"${process.execPath}" -e "console.('${unicode}');"`;
|
|
|
|
cp.exec(cmd, {maxBuffer: 10}, checkFactory('stderr'));
|
|
}
|