mirror of
https://github.com/nodejs/node.git
synced 2025-05-06 00:30:06 +00:00
720d01f006
As per ecma-262 2015's #sec-%typedarray%-buffer-byteoffset-length,
`offset` would be an integer, not a 32 bit unsigned integer. Also,
`length` would be an integer with the maximum value of 2^53 - 1, not a
32 bit unsigned integer.
This would be a problem because, if we create a buffer from an
arraybuffer, from an offset which is greater than 2^32, it would be
actually pointing to a different location in arraybuffer. For example,
if we use 2^40 as offset, then the actual value used will be 0,
because `byteOffset >>>= 0` will convert `byteOffset` to a 32 bit
unsigned int, which is based on 2^32 modulo.
This is a redo, as the ca37fa527f broke
CI.
Refer: https://github.com/nodejs/node/pull/9814
Refer: https://github.com/nodejs/node/pull/9492
PR-URL: https://github.com/nodejs/node/pull/9815
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
42 lines
1.1 KiB
JavaScript
42 lines
1.1 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
|
|
function test(arrayBuffer, offset, length) {
|
|
const uint8Array = new Uint8Array(arrayBuffer, offset, length);
|
|
for (let i = 0; i < length; i += 1) {
|
|
uint8Array[i] = 1;
|
|
}
|
|
|
|
const buffer = Buffer.from(arrayBuffer, offset, length);
|
|
for (let i = 0; i < length; i += 1) {
|
|
assert.strictEqual(buffer[i], 1);
|
|
}
|
|
}
|
|
|
|
const acceptableOOMErrors = [
|
|
'Array buffer allocation failed',
|
|
'Invalid array buffer length'
|
|
];
|
|
|
|
const testCases = [
|
|
[200, 50, 100],
|
|
[4294967296 /* 1 << 32 */, 2147483648 /* 1 << 31 */, 1000],
|
|
[8589934592 /* 1 << 33 */, 4294967296 /* 1 << 32 */, 1000]
|
|
];
|
|
|
|
for (let index = 0, arrayBuffer; index < testCases.length; index += 1) {
|
|
const [size, offset, length] = testCases[index];
|
|
|
|
try {
|
|
arrayBuffer = new ArrayBuffer(size);
|
|
} catch (e) {
|
|
if (e instanceof RangeError && acceptableOOMErrors.includes(e.message))
|
|
return common.skip(`Unable to allocate ${size} bytes for ArrayBuffer`);
|
|
throw e;
|
|
}
|
|
|
|
test(arrayBuffer, offset, length);
|
|
}
|