mirror of
https://github.com/nodejs/node.git
synced 2025-05-02 03:31:35 +00:00
6c25f2ea49
- Add an accessor property `initialized `to FSEventWrap to check the state of the handle from the JS land - Introduce ERR_FS_WATCHER_ALREADY_STARTED so calling start() on a watcher that is already started will throw instead of doing nothing silently. - Introduce ERR_FS_WATCHER_NOT_STARTED so calling close() on a watcher that is already closed will throw instead of doing nothing silently. - Validate the filename passed to fs.watch() - Assert that the handle in the watcher are instances of FSEvent instead of relying on the illegal invocation error from the VM. - Add more assertions in FSEventWrap methods now that we check `initialized` and the filename in JS land before invoking the binding. - Use uvException instead of errornoException to create the errors with the error numbers from libuv to make them consistent with other errors in fs. TODO: - Improve fs.watchFile() the same way this patch improves fs.watch() - It seems possible to fire both rename and change event from libuv together now that we can check if the handle is closed via `initialized` in JS land. PR-URL: https://github.com/nodejs/node/pull/19089 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> |
||
|---|---|---|
| .. | ||
| _toc.md | ||
| addons.md | ||
| all.md | ||
| assert.md | ||
| async_hooks.md | ||
| buffer.md | ||
| child_process.md | ||
| cli.md | ||
| cluster.md | ||
| console.md | ||
| crypto.md | ||
| debugger.md | ||
| deprecations.md | ||
| dgram.md | ||
| dns.md | ||
| documentation.md | ||
| domain.md | ||
| errors.md | ||
| esm.md | ||
| events.md | ||
| fs.md | ||
| globals.md | ||
| http2.md | ||
| http.md | ||
| https.md | ||
| index.md | ||
| inspector.md | ||
| intl.md | ||
| modules.md | ||
| n-api.md | ||
| net.md | ||
| os.md | ||
| path.md | ||
| perf_hooks.md | ||
| process.md | ||
| punycode.md | ||
| querystring.md | ||
| readline.md | ||
| repl.md | ||
| stream.md | ||
| string_decoder.md | ||
| synopsis.md | ||
| timers.md | ||
| tls.md | ||
| tracing.md | ||
| tty.md | ||
| url.md | ||
| util.md | ||
| v8.md | ||
| vm.md | ||
| zlib.md | ||