mirror of
https://github.com/nodejs/node.git
synced 2025-05-11 12:55:53 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
33 lines
1.1 KiB
JavaScript
33 lines
1.1 KiB
JavaScript
'use strict';
|
|
// Flags: --expose-gc
|
|
|
|
const common = require('../../common');
|
|
const test_general = require(`./build/${common.buildType}/test_general`);
|
|
const assert = require('assert');
|
|
|
|
let finalized = {};
|
|
const callback = common.mustCall(2);
|
|
|
|
// Add two items to be finalized and ensure the callback is called for each.
|
|
test_general.addFinalizerOnly(finalized, callback);
|
|
test_general.addFinalizerOnly(finalized, callback);
|
|
|
|
// Ensure attached items cannot be retrieved.
|
|
assert.throws(() => test_general.unwrap(finalized),
|
|
{ name: 'Error', message: 'Invalid argument' });
|
|
|
|
// Ensure attached items cannot be removed.
|
|
assert.throws(() => test_general.removeWrap(finalized),
|
|
{ name: 'Error', message: 'Invalid argument' });
|
|
finalized = null;
|
|
global.gc();
|
|
|
|
// Add an item to an object that is already wrapped, and ensure that its
|
|
// finalizer as well as the wrap finalizer gets called.
|
|
let finalizeAndWrap = {};
|
|
test_general.wrap(finalizeAndWrap);
|
|
test_general.addFinalizerOnly(finalizeAndWrap, common.mustCall());
|
|
finalizeAndWrap = null;
|
|
global.gc();
|
|
assert.strictEqual(test_general.derefItemWasCalled(), true);
|