mirror of
https://github.com/nodejs/node.git
synced 2025-05-21 06:53:52 +00:00
641b0135cf
Check that the return value and callback error for tls.renegotiate() does not indicate a failure. Also, remove unnecessary line wrapping and indentation. PR-URL: https://github.com/nodejs/node/pull/25437 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
71 lines
2.2 KiB
JavaScript
71 lines
2.2 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const fixtures = require('../common/fixtures');
|
|
|
|
// Tests that calling disableRenegotiation on a TLSSocket stops renegotiation.
|
|
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
|
|
const tls = require('tls');
|
|
|
|
const options = {
|
|
key: fixtures.readKey('agent1-key.pem'),
|
|
cert: fixtures.readKey('agent1-cert.pem'),
|
|
};
|
|
|
|
const server = tls.Server(options, common.mustCall((socket) => {
|
|
socket.on('error', common.mustCall((err) => {
|
|
common.expectsError({
|
|
type: Error,
|
|
code: 'ERR_TLS_RENEGOTIATION_DISABLED',
|
|
message: 'TLS session renegotiation disabled for this socket'
|
|
})(err);
|
|
socket.destroy();
|
|
server.close();
|
|
}));
|
|
// Disable renegotiation after the first chunk of data received.
|
|
// Demonstrates that renegotiation works successfully up until
|
|
// disableRenegotiation is called.
|
|
socket.on('data', common.mustCall((chunk) => {
|
|
socket.write(chunk);
|
|
socket.disableRenegotiation();
|
|
}));
|
|
socket.on('secure', common.mustCall(() => {
|
|
assert(socket._handle.handshakes < 2,
|
|
`Too many handshakes [${socket._handle.handshakes}]`);
|
|
}));
|
|
}));
|
|
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const port = server.address().port;
|
|
const options = {
|
|
rejectUnauthorized: false,
|
|
port
|
|
};
|
|
const client = tls.connect(options, common.mustCall(() => {
|
|
client.write('');
|
|
// Negotiation is still permitted for this first
|
|
// attempt. This should succeed.
|
|
let ok = client.renegotiate(options, common.mustCall((err) => {
|
|
assert.ifError(err);
|
|
// Once renegotiation completes, we write some
|
|
// data to the socket, which triggers the on
|
|
// data event on the server. After that data
|
|
// is received, disableRenegotiation is called.
|
|
client.write('data', common.mustCall(() => {
|
|
client.write('');
|
|
// This second renegotiation attempt should fail
|
|
// and the callback should never be invoked. The
|
|
// server will simply drop the connection after
|
|
// emitting the error.
|
|
ok = client.renegotiate(options, common.mustNotCall());
|
|
assert.strictEqual(ok, true);
|
|
}));
|
|
}));
|
|
assert.strictEqual(ok, true);
|
|
}));
|
|
}));
|