mirror of
https://github.com/nodejs/node.git
synced 2025-05-06 03:45:25 +00:00
5dafb435d8
This commit fixes an inconsistency in querystring.escape objects handling compared to native encodeURIComponent function. Fixes: https://github.com/nodejs/node/issues/5309 PR-URL: https://github.com/nodejs/node/pull/5341 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
25 lines
705 B
JavaScript
25 lines
705 B
JavaScript
'use strict';
|
|
require('../common');
|
|
const assert = require('assert');
|
|
|
|
const qs = require('querystring');
|
|
|
|
assert.deepEqual(qs.escape(5), '5');
|
|
assert.deepEqual(qs.escape('test'), 'test');
|
|
assert.deepEqual(qs.escape({}), '%5Bobject%20Object%5D');
|
|
assert.deepEqual(qs.escape([5, 10]), '5%2C10');
|
|
|
|
// using toString for objects
|
|
assert.strictEqual(
|
|
qs.escape({test: 5, toString: () => 'test', valueOf: () => 10 }),
|
|
'test'
|
|
);
|
|
|
|
// toString is not callable, must throw an error
|
|
assert.throws(() => qs.escape({toString: 5}));
|
|
|
|
// should use valueOf instead of non-callable toString
|
|
assert.strictEqual(qs.escape({toString: 5, valueOf: () => 'test'}), 'test');
|
|
|
|
assert.throws(() => qs.escape(Symbol('test')));
|