mirror of
https://github.com/nodejs/node.git
synced 2025-05-20 05:01:48 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
42 lines
892 B
JavaScript
42 lines
892 B
JavaScript
'use strict';
|
|
// From: https://github.com/w3c/web-platform-tests/blob/master/encoding/api-invalid-label.html
|
|
// With the twist that we specifically test for Node.js error codes
|
|
|
|
require('../common');
|
|
const assert = require('assert');
|
|
|
|
[
|
|
'utf-8',
|
|
'unicode-1-1-utf-8',
|
|
'utf8',
|
|
'utf-16be',
|
|
'utf-16le',
|
|
'utf-16'
|
|
].forEach((i) => {
|
|
['\u0000', '\u000b', '\u00a0', '\u2028', '\u2029'].forEach((ws) => {
|
|
assert.throws(
|
|
() => new TextDecoder(`${ws}${i}`),
|
|
{
|
|
code: 'ERR_ENCODING_NOT_SUPPORTED',
|
|
name: 'RangeError'
|
|
}
|
|
);
|
|
|
|
assert.throws(
|
|
() => new TextDecoder(`${i}${ws}`),
|
|
{
|
|
code: 'ERR_ENCODING_NOT_SUPPORTED',
|
|
name: 'RangeError'
|
|
}
|
|
);
|
|
|
|
assert.throws(
|
|
() => new TextDecoder(`${ws}${i}${ws}`),
|
|
{
|
|
code: 'ERR_ENCODING_NOT_SUPPORTED',
|
|
name: 'RangeError'
|
|
}
|
|
);
|
|
});
|
|
});
|