mirror of
https://github.com/nodejs/node.git
synced 2025-05-20 05:01:48 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
39 lines
1.0 KiB
JavaScript
39 lines
1.0 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const url = require('url');
|
|
|
|
// https://github.com/joyent/node/issues/568
|
|
[
|
|
[undefined, 'undefined'],
|
|
[null, 'object'],
|
|
[true, 'boolean'],
|
|
[false, 'boolean'],
|
|
[0.0, 'number'],
|
|
[0, 'number'],
|
|
[[], 'object'],
|
|
[{}, 'object'],
|
|
[() => {}, 'function'],
|
|
[Symbol('foo'), 'symbol']
|
|
].forEach(([val, type]) => {
|
|
assert.throws(() => {
|
|
url.parse(val);
|
|
}, {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "url" argument must be of type string.' +
|
|
common.invalidArgTypeHelper(val)
|
|
});
|
|
});
|
|
|
|
assert.throws(() => { url.parse('http://%E0%A4%A@fail'); },
|
|
(e) => {
|
|
// The error should be a URIError.
|
|
if (!(e instanceof URIError))
|
|
return false;
|
|
|
|
// The error should be from the JS engine and not from Node.js.
|
|
// JS engine errors do not have the `code` property.
|
|
return e.code === undefined;
|
|
});
|