mirror of
https://github.com/nodejs/node.git
synced 2025-05-20 06:53:51 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
53 lines
1.2 KiB
JavaScript
53 lines
1.2 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const http2 = require('http2');
|
|
|
|
const server = http2.createServer();
|
|
|
|
// Each of these headers must appear only once
|
|
const singles = [
|
|
'content-type',
|
|
'user-agent',
|
|
'referer',
|
|
'authorization',
|
|
'proxy-authorization',
|
|
'if-modified-since',
|
|
'if-unmodified-since',
|
|
'from',
|
|
'location',
|
|
'max-forwards'
|
|
];
|
|
|
|
server.on('stream', common.mustNotCall());
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const client = http2.connect(`http://localhost:${server.address().port}`);
|
|
|
|
singles.forEach((i) => {
|
|
assert.throws(
|
|
() => client.request({ [i]: 'abc', [i.toUpperCase()]: 'xyz' }),
|
|
{
|
|
code: 'ERR_HTTP2_HEADER_SINGLE_VALUE',
|
|
name: 'TypeError',
|
|
message: `Header field "${i}" must only have a single value`
|
|
}
|
|
);
|
|
|
|
assert.throws(
|
|
() => client.request({ [i]: ['abc', 'xyz'] }),
|
|
{
|
|
code: 'ERR_HTTP2_HEADER_SINGLE_VALUE',
|
|
name: 'TypeError',
|
|
message: `Header field "${i}" must only have a single value`
|
|
}
|
|
);
|
|
});
|
|
|
|
server.close();
|
|
client.close();
|
|
}));
|