mirror of
https://github.com/nodejs/node.git
synced 2025-05-19 23:36:56 +00:00

Fix AbortSignal in Spawn which doesn't actually abort the process, and fork can emit an AbortError even if the process was already exited. Add documentation For killSignal. Fixes: https://github.com/nodejs/node/issues/37273 PR-URL: https://github.com/nodejs/node/pull/37325 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
73 lines
1.9 KiB
JavaScript
73 lines
1.9 KiB
JavaScript
'use strict';
|
|
|
|
const { mustCall, mustNotCall } = require('../common');
|
|
const { strictEqual } = require('assert');
|
|
const fixtures = require('../common/fixtures');
|
|
const { fork } = require('child_process');
|
|
|
|
{
|
|
// Test aborting a forked child_process after calling fork
|
|
const ac = new AbortController();
|
|
const { signal } = ac;
|
|
const cp = fork(fixtures.path('child-process-stay-alive-forever.js'), {
|
|
signal
|
|
});
|
|
cp.on('exit', mustCall((code, killSignal) => {
|
|
strictEqual(code, null);
|
|
strictEqual(killSignal, 'SIGTERM');
|
|
}));
|
|
cp.on('error', mustCall((err) => {
|
|
strictEqual(err.name, 'AbortError');
|
|
}));
|
|
process.nextTick(() => ac.abort());
|
|
}
|
|
{
|
|
// Test passing an already aborted signal to a forked child_process
|
|
const ac = new AbortController();
|
|
const { signal } = ac;
|
|
ac.abort();
|
|
const cp = fork(fixtures.path('child-process-stay-alive-forever.js'), {
|
|
signal
|
|
});
|
|
cp.on('exit', mustCall((code, killSignal) => {
|
|
strictEqual(code, null);
|
|
strictEqual(killSignal, 'SIGTERM');
|
|
}));
|
|
cp.on('error', mustCall((err) => {
|
|
strictEqual(err.name, 'AbortError');
|
|
}));
|
|
}
|
|
|
|
{
|
|
// Test passing a different kill signal
|
|
const ac = new AbortController();
|
|
const { signal } = ac;
|
|
ac.abort();
|
|
const cp = fork(fixtures.path('child-process-stay-alive-forever.js'), {
|
|
signal,
|
|
killSignal: 'SIGKILL',
|
|
});
|
|
cp.on('exit', mustCall((code, killSignal) => {
|
|
strictEqual(code, null);
|
|
strictEqual(killSignal, 'SIGKILL');
|
|
}));
|
|
cp.on('error', mustCall((err) => {
|
|
strictEqual(err.name, 'AbortError');
|
|
}));
|
|
}
|
|
|
|
{
|
|
// Test aborting a cp before close but after exit
|
|
const ac = new AbortController();
|
|
const { signal } = ac;
|
|
const cp = fork(fixtures.path('child-process-stay-alive-forever.js'), {
|
|
signal
|
|
});
|
|
cp.on('exit', mustCall(() => {
|
|
ac.abort();
|
|
}));
|
|
cp.on('error', mustNotCall());
|
|
|
|
setTimeout(() => cp.kill(), 1);
|
|
}
|