mirror of
https://github.com/nodejs/node.git
synced 2025-05-09 19:38:23 +00:00
5ba868f024
This adds a new `--tls-cipher-list` command line switch
that can be used to override the built-in default cipher
list. The intent of this is to make it possible to enforce
an alternative default cipher list at the process level.
Overriding the default cipher list is still permitted at
the application level by changing the value of
`require('tls').DEFAULT_CIPHERS`.
As part of the change, the built in default list is moved
out of tls.js and into node_constants.h and node_constants.cc.
Two new constants are added to require('constants'):
* defaultCipherList (the active default cipher list)
* defaultCoreCipherList (the built-in default cipher list)
A test case and doc changes are included.
A new NODE_DEFINE_STRING_CONSTANT macro is also created in
node_internals.h
When node_constants is initialized, it will pick up either
the passed in command line switch or fallback to the default
built-in suite.
Within joyent/node, this change had originaly been wrapped
up with a number of other related commits involving the
removal of the RC4 cipher. This breaks out this isolated
change.
/cc @mhdawson, @misterdjules, @trevnorris, @indutny, @rvagg
Reviewed By: Ben Noordhuis <ben@strongloop.com>
PR-URL: https://github.com/nodejs/node/pull/2412
33 lines
808 B
JavaScript
33 lines
808 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
|
|
if (!common.hasCrypto) {
|
|
console.log('1..0 # Skipped: missing crypto');
|
|
return;
|
|
}
|
|
|
|
const assert = require('assert');
|
|
const spawn = require('child_process').spawn;
|
|
const defaultCoreList = require('constants').defaultCoreCipherList;
|
|
|
|
function doCheck(arg, check) {
|
|
var out = '';
|
|
var arg = arg.concat([
|
|
'-pe',
|
|
'require("constants").defaultCipherList'
|
|
]);
|
|
spawn(process.execPath, arg, {}).
|
|
on('error', assert.fail).
|
|
stdout.on('data', function(chunk) {
|
|
out += chunk;
|
|
}).on('end', function() {
|
|
assert.equal(out.trim(), check);
|
|
}).on('error', assert.fail);
|
|
}
|
|
|
|
// test the default unmodified version
|
|
doCheck([], defaultCoreList);
|
|
|
|
// test the command line switch by itself
|
|
doCheck(['--tls-cipher-list=ABC'], 'ABC');
|