mirror of
https://github.com/nodejs/node.git
synced 2025-05-05 17:10:40 +00:00
59d3d542d6
Display Node.js version at the end of stacktraces on fatal exception that causes exit. Easier for debugging so you don't have to ask "what node version are you on?", it is directly in the error the user copy/paste from when asking for help. Fixes: https://github.com/nodejs/node/issues/29731 PR-URL: https://github.com/nodejs/node/pull/38332 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michaël Zasso <targos@protonmail.com>
82 lines
2.9 KiB
JavaScript
82 lines
2.9 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const exec = require('child_process').exec;
|
|
const fixtures = require('../common/fixtures');
|
|
|
|
function errExec(script, callback) {
|
|
const cmd = `"${process.argv[0]}" "${fixtures.path(script)}"`;
|
|
return exec(cmd, (err, stdout, stderr) => {
|
|
// There was some error
|
|
assert.ok(err);
|
|
|
|
// More than one line of error output.
|
|
assert.ok(stderr.split('\n').length);
|
|
|
|
// Proxy the args for more tests.
|
|
callback(err, stdout, stderr);
|
|
});
|
|
}
|
|
|
|
const syntaxErrorMessage = /\bSyntaxError\b/;
|
|
|
|
|
|
// Simple throw error
|
|
errExec('throws_error.js', common.mustCall((err, stdout, stderr) => {
|
|
assert.match(stderr, /blah/);
|
|
}));
|
|
|
|
|
|
// Trying to JSON.parse(undefined)
|
|
errExec('throws_error2.js', common.mustCall((err, stdout, stderr) => {
|
|
assert.match(stderr, syntaxErrorMessage);
|
|
}));
|
|
|
|
|
|
// Trying to JSON.parse(undefined) in nextTick
|
|
errExec('throws_error3.js', common.mustCall((err, stdout, stderr) => {
|
|
assert.match(stderr, syntaxErrorMessage);
|
|
}));
|
|
|
|
|
|
// throw ILLEGAL error
|
|
errExec('throws_error4.js', common.mustCall((err, stdout, stderr) => {
|
|
assert.match(stderr, syntaxErrorMessage);
|
|
}));
|
|
|
|
// Specific long exception line doesn't result in stack overflow
|
|
errExec('throws_error5.js', common.mustCall((err, stdout, stderr) => {
|
|
assert.match(stderr, syntaxErrorMessage);
|
|
}));
|
|
|
|
// Long exception line with length > errorBuffer doesn't result in assertion
|
|
errExec('throws_error6.js', common.mustCall((err, stdout, stderr) => {
|
|
assert.match(stderr, syntaxErrorMessage);
|
|
}));
|
|
|
|
// Object that throws in toString() doesn't print garbage
|
|
errExec('throws_error7.js', common.mustCall((err, stdout, stderr) => {
|
|
assert.match(stderr, /throw {\r?\n\^\r?\n{ toString: \[Function: toString] }\r?\n\r?\nNode\.js \S+\r?\n$/);
|
|
}));
|