mirror of
https://github.com/nodejs/node.git
synced 2025-05-03 15:17:17 +00:00
5f2c4ce74f
https://github.com/nodejs/node-v8/pull/147 broke the `vm.measureMemory()` API. It only created a `MeasureMemoryDelegate` and without actually calling `v8::Isolate::MeasureMemory()` so the returned promise will never resolve. This was not caught by the tests because the promise resolvers were not wrapped with `common.mustCall()`. This patch migrates the API properly and also introduce the newly added execution option to the API. It also removes support for specifying contexts to measure - instead we'll just return the measurements for all contexts in the detailed mode, which is what the `performance.measureMemory()` prototype in V8 currently does. We can consider implementing our own `v8::MeasureMemoryDelegate` to select the target context in `ShouldMeasure()` in the future, but then we'll also need to implement `MeasurementComplete()` to assemble the result. For now it's probably too early to do that. Since this API is still experimental (and guarded with a warning), such breakage should be acceptable. Refs: https://github.com/nodejs/node-v8/pull/147 PR-URL: https://github.com/nodejs/node/pull/32988 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
38 lines
727 B
JavaScript
38 lines
727 B
JavaScript
// Flags: --expose-gc
|
|
|
|
'use strict';
|
|
const common = require('../common');
|
|
const {
|
|
assertSummaryShape,
|
|
expectExperimentalWarning
|
|
} = require('../common/measure-memory');
|
|
const vm = require('vm');
|
|
|
|
expectExperimentalWarning();
|
|
|
|
// Test lazy memory measurement - we will need to global.gc()
|
|
// or otherwise these may not resolve.
|
|
{
|
|
vm.measureMemory()
|
|
.then(common.mustCall(assertSummaryShape));
|
|
global.gc();
|
|
}
|
|
|
|
{
|
|
vm.measureMemory({})
|
|
.then(common.mustCall(assertSummaryShape));
|
|
global.gc();
|
|
}
|
|
|
|
{
|
|
vm.measureMemory({ mode: 'summary' })
|
|
.then(common.mustCall(assertSummaryShape));
|
|
global.gc();
|
|
}
|
|
|
|
{
|
|
vm.measureMemory({ mode: 'detailed' })
|
|
.then(common.mustCall(assertSummaryShape));
|
|
global.gc();
|
|
}
|