mirror of
https://github.com/nodejs/node.git
synced 2025-05-03 05:19:11 +00:00
7fea0108d5
These objects are dictionaries, and a query can return columns with special names like `__proto__` (which would be ignored without this change). Also construct the object by passing vectors of properties for better performance and improve error handling by using `MaybeLocal`. PR-URL: https://github.com/nodejs/node/pull/54350 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
81 lines
2.5 KiB
JavaScript
81 lines
2.5 KiB
JavaScript
// Flags: --experimental-sqlite
|
|
'use strict';
|
|
require('../common');
|
|
const tmpdir = require('../common/tmpdir');
|
|
const { join } = require('node:path');
|
|
const { DatabaseSync } = require('node:sqlite');
|
|
const { suite, test } = require('node:test');
|
|
let cnt = 0;
|
|
|
|
tmpdir.refresh();
|
|
|
|
function nextDb() {
|
|
return join(tmpdir.path, `database-${cnt++}.db`);
|
|
}
|
|
|
|
suite('named parameters', () => {
|
|
test('throws on unknown named parameters', (t) => {
|
|
const db = new DatabaseSync(nextDb());
|
|
t.after(() => { db.close(); });
|
|
const setup = db.exec(
|
|
'CREATE TABLE types(key INTEGER PRIMARY KEY, val INTEGER) STRICT;'
|
|
);
|
|
t.assert.strictEqual(setup, undefined);
|
|
|
|
t.assert.throws(() => {
|
|
const stmt = db.prepare('INSERT INTO types (key, val) VALUES ($k, $v)');
|
|
stmt.run({ $k: 1, $unknown: 1 });
|
|
}, {
|
|
code: 'ERR_INVALID_STATE',
|
|
message: /Unknown named parameter '\$unknown'/,
|
|
});
|
|
});
|
|
|
|
test('bare named parameters are supported', (t) => {
|
|
const db = new DatabaseSync(nextDb());
|
|
t.after(() => { db.close(); });
|
|
const setup = db.exec(
|
|
'CREATE TABLE data(key INTEGER PRIMARY KEY, val INTEGER) STRICT;'
|
|
);
|
|
t.assert.strictEqual(setup, undefined);
|
|
const stmt = db.prepare('INSERT INTO data (key, val) VALUES ($k, $v)');
|
|
stmt.run({ k: 1, v: 9 });
|
|
t.assert.deepStrictEqual(
|
|
db.prepare('SELECT * FROM data').get(),
|
|
{ __proto__: null, key: 1, val: 9 },
|
|
);
|
|
});
|
|
|
|
test('duplicate bare named parameters are supported', (t) => {
|
|
const db = new DatabaseSync(nextDb());
|
|
t.after(() => { db.close(); });
|
|
const setup = db.exec(
|
|
'CREATE TABLE data(key INTEGER PRIMARY KEY, val INTEGER) STRICT;'
|
|
);
|
|
t.assert.strictEqual(setup, undefined);
|
|
const stmt = db.prepare('INSERT INTO data (key, val) VALUES ($k, $k)');
|
|
stmt.run({ k: 1 });
|
|
t.assert.deepStrictEqual(
|
|
db.prepare('SELECT * FROM data').get(),
|
|
{ __proto__: null, key: 1, val: 1 },
|
|
);
|
|
});
|
|
|
|
test('bare named parameters throw on ambiguous names', (t) => {
|
|
const db = new DatabaseSync(nextDb());
|
|
t.after(() => { db.close(); });
|
|
const setup = db.exec(
|
|
'CREATE TABLE types(key INTEGER PRIMARY KEY, val INTEGER) STRICT;'
|
|
);
|
|
t.assert.strictEqual(setup, undefined);
|
|
const stmt = db.prepare('INSERT INTO types (key, val) VALUES ($k, @k)');
|
|
t.assert.throws(() => {
|
|
stmt.run({ k: 1 });
|
|
}, {
|
|
code: 'ERR_INVALID_STATE',
|
|
message: 'Cannot create bare named parameter \'k\' because of ' +
|
|
'conflicting names \'$k\' and \'@k\'.',
|
|
});
|
|
});
|
|
});
|