mirror of
https://github.com/nodejs/node.git
synced 2025-05-03 13:00:17 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
49 lines
1.2 KiB
JavaScript
49 lines
1.2 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const dgram = require('dgram');
|
|
const dns = require('dns');
|
|
|
|
{
|
|
// Verify that the provided lookup function is called.
|
|
const lookup = common.mustCall((host, family, callback) => {
|
|
dns.lookup(host, family, callback);
|
|
});
|
|
|
|
const socket = dgram.createSocket({ type: 'udp4', lookup });
|
|
|
|
socket.bind(common.mustCall(() => {
|
|
socket.close();
|
|
}));
|
|
}
|
|
|
|
{
|
|
// Verify that lookup defaults to dns.lookup().
|
|
const originalLookup = dns.lookup;
|
|
|
|
dns.lookup = common.mustCall((host, family, callback) => {
|
|
dns.lookup = originalLookup;
|
|
originalLookup(host, family, callback);
|
|
});
|
|
|
|
const socket = dgram.createSocket({ type: 'udp4' });
|
|
|
|
socket.bind(common.mustCall(() => {
|
|
socket.close();
|
|
}));
|
|
}
|
|
|
|
{
|
|
// Verify that non-functions throw.
|
|
[null, true, false, 0, 1, NaN, '', 'foo', {}, Symbol()].forEach((value) => {
|
|
assert.throws(() => {
|
|
dgram.createSocket({ type: 'udp4', lookup: value });
|
|
}, {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "lookup" argument must be of type function.' +
|
|
common.invalidArgTypeHelper(value)
|
|
});
|
|
});
|
|
}
|