mirror of
https://github.com/nodejs/node.git
synced 2025-04-28 21:46:48 +00:00

When the entry point is a module and the graph it imports still contains unsettled top-level await when the Node.js instance finishes the event loop, search from the entry point module for unsettled top-level await and print their location. To avoid unnecessary overhead, we register a promise that only gets settled when the entry point graph evaluation returns from await, and only search the module graph if it's still unsettled by the time the instance is exiting. This patch only handles this for entry point modules. Other kinds of modules are more complicated so will be left for the future. Drive-by: update the terminology "unfinished promise" to the more correct one "unsettled promise" in the codebase. PR-URL: https://github.com/nodejs/node/pull/51999 Fixes: https://github.com/nodejs/node/issues/42868 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
260 lines
9.0 KiB
JavaScript
260 lines
9.0 KiB
JavaScript
'use strict';
|
|
|
|
const {
|
|
ArrayPrototypeJoin,
|
|
ArrayPrototypePush,
|
|
ArrayPrototypeSome,
|
|
FunctionPrototype,
|
|
ObjectSetPrototypeOf,
|
|
PromiseResolve,
|
|
PromisePrototypeThen,
|
|
ReflectApply,
|
|
RegExpPrototypeExec,
|
|
RegExpPrototypeSymbolReplace,
|
|
SafePromiseAllReturnArrayLike,
|
|
SafePromiseAllReturnVoid,
|
|
SafeSet,
|
|
StringPrototypeIncludes,
|
|
StringPrototypeSplit,
|
|
StringPrototypeStartsWith,
|
|
globalThis,
|
|
} = primordials;
|
|
|
|
const { ModuleWrap } = internalBinding('module_wrap');
|
|
const {
|
|
privateSymbols: {
|
|
entry_point_module_private_symbol,
|
|
},
|
|
} = internalBinding('util');
|
|
const { decorateErrorStack, kEmptyObject } = require('internal/util');
|
|
const {
|
|
getSourceMapsEnabled,
|
|
} = require('internal/source_map/source_map_cache');
|
|
const assert = require('internal/assert');
|
|
const resolvedPromise = PromiseResolve();
|
|
const {
|
|
setHasStartedUserESMExecution,
|
|
} = require('internal/modules/helpers');
|
|
const noop = FunctionPrototype;
|
|
|
|
let hasPausedEntry = false;
|
|
|
|
const CJSGlobalLike = [
|
|
'require',
|
|
'module',
|
|
'exports',
|
|
'__filename',
|
|
'__dirname',
|
|
];
|
|
const isCommonJSGlobalLikeNotDefinedError = (errorMessage) =>
|
|
ArrayPrototypeSome(
|
|
CJSGlobalLike,
|
|
(globalLike) => errorMessage === `${globalLike} is not defined`,
|
|
);
|
|
|
|
/* A ModuleJob tracks the loading of a single Module, and the ModuleJobs of
|
|
* its dependencies, over time. */
|
|
class ModuleJob {
|
|
// `loader` is the Loader instance used for loading dependencies.
|
|
// `moduleProvider` is a function
|
|
constructor(loader, url, importAttributes = { __proto__: null },
|
|
moduleProvider, isMain, inspectBrk, sync = false) {
|
|
this.loader = loader;
|
|
this.importAttributes = importAttributes;
|
|
this.isMain = isMain;
|
|
this.inspectBrk = inspectBrk;
|
|
|
|
this.url = url;
|
|
|
|
this.module = undefined;
|
|
// Expose the promise to the ModuleWrap directly for linking below.
|
|
// `this.module` is also filled in below.
|
|
this.modulePromise = ReflectApply(moduleProvider, loader, [url, isMain]);
|
|
|
|
if (sync) {
|
|
this.module = this.modulePromise;
|
|
this.modulePromise = PromiseResolve(this.module);
|
|
} else {
|
|
this.modulePromise = PromiseResolve(this.modulePromise);
|
|
}
|
|
|
|
// Wait for the ModuleWrap instance being linked with all dependencies.
|
|
const link = async () => {
|
|
this.module = await this.modulePromise;
|
|
assert(this.module instanceof ModuleWrap);
|
|
|
|
// Explicitly keeping track of dependency jobs is needed in order
|
|
// to flatten out the dependency graph below in `_instantiate()`,
|
|
// so that circular dependencies can't cause a deadlock by two of
|
|
// these `link` callbacks depending on each other.
|
|
const dependencyJobs = [];
|
|
const promises = this.module.link(async (specifier, attributes) => {
|
|
const job = await this.loader.getModuleJob(specifier, url, attributes);
|
|
ArrayPrototypePush(dependencyJobs, job);
|
|
return job.modulePromise;
|
|
});
|
|
|
|
if (promises !== undefined) {
|
|
await SafePromiseAllReturnVoid(promises);
|
|
}
|
|
|
|
return SafePromiseAllReturnArrayLike(dependencyJobs);
|
|
};
|
|
// Promise for the list of all dependencyJobs.
|
|
this.linked = link();
|
|
// This promise is awaited later anyway, so silence
|
|
// 'unhandled rejection' warnings.
|
|
PromisePrototypeThen(this.linked, undefined, noop);
|
|
|
|
// instantiated == deep dependency jobs wrappers are instantiated,
|
|
// and module wrapper is instantiated.
|
|
this.instantiated = undefined;
|
|
}
|
|
|
|
instantiate() {
|
|
if (this.instantiated === undefined) {
|
|
this.instantiated = this._instantiate();
|
|
}
|
|
return this.instantiated;
|
|
}
|
|
|
|
async _instantiate() {
|
|
const jobsInGraph = new SafeSet();
|
|
const addJobsToDependencyGraph = async (moduleJob) => {
|
|
if (jobsInGraph.has(moduleJob)) {
|
|
return;
|
|
}
|
|
jobsInGraph.add(moduleJob);
|
|
const dependencyJobs = await moduleJob.linked;
|
|
return SafePromiseAllReturnVoid(dependencyJobs, addJobsToDependencyGraph);
|
|
};
|
|
await addJobsToDependencyGraph(this);
|
|
|
|
try {
|
|
if (!hasPausedEntry && this.inspectBrk) {
|
|
hasPausedEntry = true;
|
|
const initWrapper = internalBinding('inspector').callAndPauseOnStart;
|
|
initWrapper(this.module.instantiate, this.module);
|
|
} else {
|
|
this.module.instantiate();
|
|
}
|
|
} catch (e) {
|
|
decorateErrorStack(e);
|
|
// TODO(@bcoe): Add source map support to exception that occurs as result
|
|
// of missing named export. This is currently not possible because
|
|
// stack trace originates in module_job, not the file itself. A hidden
|
|
// symbol with filename could be set in node_errors.cc to facilitate this.
|
|
if (!getSourceMapsEnabled() &&
|
|
StringPrototypeIncludes(e.message,
|
|
' does not provide an export named')) {
|
|
const splitStack = StringPrototypeSplit(e.stack, '\n');
|
|
const parentFileUrl = RegExpPrototypeSymbolReplace(
|
|
/:\d+$/,
|
|
splitStack[0],
|
|
'',
|
|
);
|
|
const { 1: childSpecifier, 2: name } = RegExpPrototypeExec(
|
|
/module '(.*)' does not provide an export named '(.+)'/,
|
|
e.message);
|
|
const { url: childFileURL } = await this.loader.resolve(
|
|
childSpecifier,
|
|
parentFileUrl,
|
|
kEmptyObject,
|
|
);
|
|
let format;
|
|
try {
|
|
// This might throw for non-CommonJS modules because we aren't passing
|
|
// in the import attributes and some formats require them; but we only
|
|
// care about CommonJS for the purposes of this error message.
|
|
({ format } =
|
|
await this.loader.load(childFileURL));
|
|
} catch {
|
|
// Continue regardless of error.
|
|
}
|
|
|
|
if (format === 'commonjs') {
|
|
const importStatement = splitStack[1];
|
|
// TODO(@ctavan): The original error stack only provides the single
|
|
// line which causes the error. For multi-line import statements we
|
|
// cannot generate an equivalent object destructuring assignment by
|
|
// just parsing the error stack.
|
|
const oneLineNamedImports = RegExpPrototypeExec(/{.*}/, importStatement);
|
|
const destructuringAssignment = oneLineNamedImports &&
|
|
RegExpPrototypeSymbolReplace(/\s+as\s+/g, oneLineNamedImports, ': ');
|
|
e.message = `Named export '${name}' not found. The requested module` +
|
|
` '${childSpecifier}' is a CommonJS module, which may not support` +
|
|
' all module.exports as named exports.\nCommonJS modules can ' +
|
|
'always be imported via the default export, for example using:' +
|
|
`\n\nimport pkg from '${childSpecifier}';\n${
|
|
destructuringAssignment ?
|
|
`const ${destructuringAssignment} = pkg;\n` : ''}`;
|
|
const newStack = StringPrototypeSplit(e.stack, '\n');
|
|
newStack[3] = `SyntaxError: ${e.message}`;
|
|
e.stack = ArrayPrototypeJoin(newStack, '\n');
|
|
}
|
|
}
|
|
throw e;
|
|
}
|
|
|
|
for (const dependencyJob of jobsInGraph) {
|
|
// Calling `this.module.instantiate()` instantiates not only the
|
|
// ModuleWrap in this module, but all modules in the graph.
|
|
dependencyJob.instantiated = resolvedPromise;
|
|
}
|
|
}
|
|
|
|
runSync() {
|
|
assert(this.module instanceof ModuleWrap);
|
|
if (this.instantiated !== undefined) {
|
|
return { __proto__: null, module: this.module };
|
|
}
|
|
|
|
this.module.instantiate();
|
|
this.instantiated = PromiseResolve();
|
|
const timeout = -1;
|
|
const breakOnSigint = false;
|
|
setHasStartedUserESMExecution();
|
|
this.module.evaluate(timeout, breakOnSigint);
|
|
return { __proto__: null, module: this.module };
|
|
}
|
|
|
|
async run(isEntryPoint = false) {
|
|
await this.instantiate();
|
|
if (isEntryPoint) {
|
|
globalThis[entry_point_module_private_symbol] = this.module;
|
|
}
|
|
const timeout = -1;
|
|
const breakOnSigint = false;
|
|
setHasStartedUserESMExecution();
|
|
try {
|
|
await this.module.evaluate(timeout, breakOnSigint);
|
|
} catch (e) {
|
|
if (e?.name === 'ReferenceError' &&
|
|
isCommonJSGlobalLikeNotDefinedError(e.message)) {
|
|
e.message += ' in ES module scope';
|
|
|
|
if (StringPrototypeStartsWith(e.message, 'require ')) {
|
|
e.message += ', you can use import instead';
|
|
}
|
|
|
|
const packageConfig =
|
|
StringPrototypeStartsWith(this.module.url, 'file://') &&
|
|
RegExpPrototypeExec(/\.js(\?[^#]*)?(#.*)?$/, this.module.url) !== null &&
|
|
require('internal/modules/package_json_reader')
|
|
.getPackageScopeConfig(this.module.url);
|
|
if (packageConfig.type === 'module') {
|
|
e.message +=
|
|
'\nThis file is being treated as an ES module because it has a ' +
|
|
`'.js' file extension and '${packageConfig.pjsonPath}' contains ` +
|
|
'"type": "module". To treat it as a CommonJS script, rename it ' +
|
|
'to use the \'.cjs\' file extension.';
|
|
}
|
|
}
|
|
throw e;
|
|
}
|
|
return { __proto__: null, module: this.module };
|
|
}
|
|
}
|
|
ObjectSetPrototypeOf(ModuleJob.prototype, null);
|
|
module.exports = ModuleJob;
|