mirror of
https://github.com/nodejs/node.git
synced 2025-05-08 09:07:45 +00:00
51898575ae
We are currenly builing Node with --shared-zlib which happens to be version 1.2.8. The test for zlib.createDeflateRaw is expected to fail but does not when using version 1.2.8. As far as I can tell the fix referred to in the comments was introduced in version 1.2.9: - Reject a window size of 256 bytes if not using the zlib wrapper This commit suggests adding a check for the version and skipping this assert if the version is less than 1.2.9. Refs: http://zlib.net/ChangeLog.txt PR-URL: https://github.com/nodejs/node/pull/13697 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
42 lines
1.2 KiB
JavaScript
42 lines
1.2 KiB
JavaScript
'use strict';
|
|
|
|
require('../common');
|
|
|
|
const assert = require('assert');
|
|
const zlib = require('zlib');
|
|
|
|
// For raw deflate encoding, requests for 256-byte windows are rejected as
|
|
// invalid by zlib (http://zlib.net/manual.html#Advanced).
|
|
// This check was introduced in version 1.2.9 and prior to that there was
|
|
// no such rejection which is the reason for the version check below
|
|
// (http://zlib.net/ChangeLog.txt).
|
|
if (!/^1\.2\.[0-8]$/.test(process.versions.zlib)) {
|
|
assert.throws(() => {
|
|
zlib.createDeflateRaw({ windowBits: 8 });
|
|
}, /^Error: Init error$/);
|
|
}
|
|
|
|
// Regression tests for bugs in the validation logic.
|
|
|
|
assert.throws(() => {
|
|
zlib.createGzip({ chunkSize: 0 });
|
|
}, /^RangeError: Invalid chunk size: 0$/);
|
|
|
|
assert.throws(() => {
|
|
zlib.createGzip({ windowBits: 0 });
|
|
}, /^RangeError: Invalid windowBits: 0$/);
|
|
|
|
assert.throws(() => {
|
|
zlib.createGzip({ memLevel: 0 });
|
|
}, /^RangeError: Invalid memLevel: 0$/);
|
|
|
|
{
|
|
const stream = zlib.createGzip({ level: NaN });
|
|
assert.strictEqual(stream._level, zlib.constants.Z_DEFAULT_COMPRESSION);
|
|
}
|
|
|
|
{
|
|
const stream = zlib.createGzip({ strategy: NaN });
|
|
assert.strictEqual(stream._strategy, zlib.constants.Z_DEFAULT_STRATEGY);
|
|
}
|