mirror of
https://github.com/nodejs/node.git
synced 2025-04-29 22:40:57 +00:00

Fix a few edge cases and non-obvious issues with nextTick: 1. Emit destroy hook in a try-finally rather than triggering it before the callback runs. 2. Re-word comment for processPromiseRejections and make sure it returns true in the rejectionHandled case too. 3. Small readability improvements. PR-URL: https://github.com/nodejs/node/pull/28047 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
50 lines
1.1 KiB
JavaScript
50 lines
1.1 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const async_hooks = require('async_hooks');
|
|
|
|
// Checks that enabling async hooks in a callback actually
|
|
// triggers after & destroy as expected.
|
|
|
|
const fnsToTest = [setTimeout, (cb) => {
|
|
setImmediate(() => {
|
|
cb();
|
|
|
|
// We need to keep the event loop open for this to actually work
|
|
// since destroy hooks are triggered in unrefed Immediates
|
|
setImmediate(() => {
|
|
hook.disable();
|
|
});
|
|
});
|
|
}, (cb) => {
|
|
process.nextTick(() => {
|
|
cb();
|
|
|
|
// We need to keep the event loop open for this to actually work
|
|
// since destroy hooks are triggered in unrefed Immediates
|
|
setImmediate(() => {
|
|
hook.disable();
|
|
assert.strictEqual(fnsToTest.length, 0);
|
|
});
|
|
});
|
|
}];
|
|
|
|
const hook = async_hooks.createHook({
|
|
before: common.mustNotCall(),
|
|
after: common.mustCall(() => {}, 3),
|
|
destroy: common.mustCall(() => {
|
|
hook.disable();
|
|
nextTest();
|
|
}, 3)
|
|
});
|
|
|
|
nextTest();
|
|
|
|
function nextTest() {
|
|
if (fnsToTest.length > 0) {
|
|
fnsToTest.shift()(common.mustCall(() => {
|
|
hook.enable();
|
|
}));
|
|
}
|
|
}
|