mirror of
https://github.com/nodejs/node.git
synced 2025-05-02 20:46:16 +00:00
4f2e372716
Export a new common.noop no-operation function for general use. Allow using common.mustCall() without a fn argument to simplify test cases. Replace various non-op functions throughout tests with common.noop PR-URL: https://github.com/nodejs/node/pull/12027 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
101 lines
2.6 KiB
JavaScript
101 lines
2.6 KiB
JavaScript
'use strict';
|
|
|
|
/*
|
|
* These tests make sure that the `options` object passed to these functions are
|
|
* never altered.
|
|
*
|
|
* Refer: https://github.com/nodejs/node/issues/7655
|
|
*/
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const path = require('path');
|
|
const fs = require('fs');
|
|
const errHandler = (e) => assert.ifError(e);
|
|
const options = Object.freeze({});
|
|
common.refreshTmpDir();
|
|
|
|
{
|
|
assert.doesNotThrow(() =>
|
|
fs.readFile(__filename, options, common.mustCall(errHandler))
|
|
);
|
|
assert.doesNotThrow(() => fs.readFileSync(__filename, options));
|
|
}
|
|
|
|
{
|
|
assert.doesNotThrow(() =>
|
|
fs.readdir(__dirname, options, common.mustCall(errHandler))
|
|
);
|
|
assert.doesNotThrow(() => fs.readdirSync(__dirname, options));
|
|
}
|
|
|
|
if (common.canCreateSymLink()) {
|
|
const sourceFile = path.resolve(common.tmpDir, 'test-readlink');
|
|
const linkFile = path.resolve(common.tmpDir, 'test-readlink-link');
|
|
|
|
fs.writeFileSync(sourceFile, '');
|
|
fs.symlinkSync(sourceFile, linkFile);
|
|
|
|
assert.doesNotThrow(() =>
|
|
fs.readlink(linkFile, options, common.mustCall(errHandler))
|
|
);
|
|
assert.doesNotThrow(() => fs.readlinkSync(linkFile, options));
|
|
}
|
|
|
|
{
|
|
const fileName = path.resolve(common.tmpDir, 'writeFile');
|
|
assert.doesNotThrow(() => fs.writeFileSync(fileName, 'ABCD', options));
|
|
assert.doesNotThrow(() =>
|
|
fs.writeFile(fileName, 'ABCD', options, common.mustCall(errHandler))
|
|
);
|
|
}
|
|
|
|
{
|
|
const fileName = path.resolve(common.tmpDir, 'appendFile');
|
|
assert.doesNotThrow(() => fs.appendFileSync(fileName, 'ABCD', options));
|
|
assert.doesNotThrow(() =>
|
|
fs.appendFile(fileName, 'ABCD', options, common.mustCall(errHandler))
|
|
);
|
|
}
|
|
|
|
if (!common.isAix) {
|
|
// TODO(thefourtheye) Remove this guard once
|
|
// https://github.com/nodejs/node/issues/5085 is fixed
|
|
{
|
|
let watch;
|
|
assert.doesNotThrow(() => {
|
|
watch = fs.watch(__filename, options, common.noop);
|
|
});
|
|
watch.close();
|
|
}
|
|
|
|
{
|
|
assert.doesNotThrow(() => fs.watchFile(__filename, options, common.noop));
|
|
fs.unwatchFile(__filename);
|
|
}
|
|
}
|
|
|
|
{
|
|
assert.doesNotThrow(() => fs.realpathSync(__filename, options));
|
|
assert.doesNotThrow(() =>
|
|
fs.realpath(__filename, options, common.mustCall(errHandler))
|
|
);
|
|
}
|
|
|
|
{
|
|
const tempFileName = path.resolve(common.tmpDir, 'mkdtemp-');
|
|
assert.doesNotThrow(() => fs.mkdtempSync(tempFileName, options));
|
|
assert.doesNotThrow(() =>
|
|
fs.mkdtemp(tempFileName, options, common.mustCall(errHandler))
|
|
);
|
|
}
|
|
|
|
{
|
|
const fileName = path.resolve(common.tmpDir, 'streams');
|
|
assert.doesNotThrow(() => {
|
|
fs.WriteStream(fileName, options).once('open', () => {
|
|
assert.doesNotThrow(() => fs.ReadStream(fileName, options));
|
|
});
|
|
});
|
|
}
|