mirror of
https://github.com/nodejs/node.git
synced 2025-05-04 08:28:40 +00:00
4ca8ff264f
This changes the error handling model of ServerHttp2Stream, ServerHttp2Request and ServerHttp2Response. An 'error' emitted on ServerHttp2Stream will not go to 'uncaughtException' anymore, but to the server 'streamError'. On the stream 'error', ServerHttp2Request will emit 'abort', while ServerHttp2Response would do nothing See: https://github.com/nodejs/node/issues/14963 PR-URL: https://github.com/nodejs/node/pull/14991 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
98 lines
2.5 KiB
JavaScript
98 lines
2.5 KiB
JavaScript
// Flags: --expose-http2 --expose-internals
|
|
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const h2 = require('http2');
|
|
const { Http2Stream } = require('internal/http2/core');
|
|
|
|
// Errors should not be reported both in Http2ServerRequest
|
|
// and Http2ServerResponse
|
|
|
|
{
|
|
let expected = null;
|
|
|
|
const server = h2.createServer();
|
|
|
|
server.on('stream', common.mustCall(function(stream) {
|
|
stream.on('error', common.mustCall(function(err) {
|
|
assert.strictEqual(err, expected);
|
|
}));
|
|
|
|
stream.resume();
|
|
stream.write('hello');
|
|
|
|
expected = new Error('kaboom');
|
|
stream.destroy(expected);
|
|
server.close();
|
|
}));
|
|
|
|
server.on('streamError', common.mustCall(function(err, stream) {
|
|
assert.strictEqual(err, expected);
|
|
assert.strictEqual(stream instanceof Http2Stream, true);
|
|
}));
|
|
|
|
server.listen(0, common.mustCall(function() {
|
|
const port = server.address().port;
|
|
|
|
const url = `http://localhost:${port}`;
|
|
const client = h2.connect(url, common.mustCall(function() {
|
|
const headers = {
|
|
':path': '/foobar',
|
|
':method': 'GET',
|
|
':scheme': 'http',
|
|
':authority': `localhost:${port}`,
|
|
};
|
|
const request = client.request(headers);
|
|
request.on('data', common.mustCall(function(chunk) {
|
|
// cause an error on the server side
|
|
client.destroy();
|
|
}));
|
|
request.end();
|
|
}));
|
|
}));
|
|
}
|
|
|
|
{
|
|
let expected = null;
|
|
|
|
const server = h2.createServer();
|
|
|
|
server.on('stream', common.mustCall(function(stream) {
|
|
// there is no 'error' handler, and this will not crash
|
|
stream.write('hello');
|
|
stream.resume();
|
|
|
|
expected = new Error('kaboom');
|
|
stream.destroy(expected);
|
|
server.close();
|
|
}));
|
|
|
|
server.on('streamError', common.mustCall(function(err, stream) {
|
|
assert.strictEqual(err, expected);
|
|
assert.strictEqual(stream instanceof Http2Stream, true);
|
|
}));
|
|
|
|
server.listen(0, common.mustCall(function() {
|
|
const port = server.address().port;
|
|
|
|
const url = `http://localhost:${port}`;
|
|
const client = h2.connect(url, common.mustCall(function() {
|
|
const headers = {
|
|
':path': '/foobar',
|
|
':method': 'GET',
|
|
':scheme': 'http',
|
|
':authority': `localhost:${port}`,
|
|
};
|
|
const request = client.request(headers);
|
|
request.on('data', common.mustCall(function(chunk) {
|
|
// cause an error on the server side
|
|
client.destroy();
|
|
}));
|
|
request.end();
|
|
}));
|
|
}));
|
|
}
|