mirror of
https://github.com/nodejs/node.git
synced 2025-05-08 12:49:23 +00:00
4ca8ff264f
This changes the error handling model of ServerHttp2Stream, ServerHttp2Request and ServerHttp2Response. An 'error' emitted on ServerHttp2Stream will not go to 'uncaughtException' anymore, but to the server 'streamError'. On the stream 'error', ServerHttp2Request will emit 'abort', while ServerHttp2Response would do nothing See: https://github.com/nodejs/node/issues/14963 PR-URL: https://github.com/nodejs/node/pull/14991 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
47 lines
1.1 KiB
JavaScript
47 lines
1.1 KiB
JavaScript
// Flags: --expose-http2
|
|
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const http2 = require('http2');
|
|
const assert = require('assert');
|
|
|
|
const {
|
|
HTTP2_HEADER_CONTENT_TYPE
|
|
} = http2.constants;
|
|
|
|
const server = http2.createServer();
|
|
server.on('stream', (stream) => {
|
|
stream.respondWithFile('../', {
|
|
[HTTP2_HEADER_CONTENT_TYPE]: 'text/plain'
|
|
}, {
|
|
onError(err) {
|
|
common.expectsError({
|
|
code: 'ERR_HTTP2_SEND_FILE',
|
|
type: Error,
|
|
message: 'Only regular files can be sent'
|
|
})(err);
|
|
|
|
stream.respond({ ':status': 404 });
|
|
stream.end();
|
|
},
|
|
statCheck: common.mustNotCall()
|
|
});
|
|
});
|
|
server.listen(0, () => {
|
|
|
|
const client = http2.connect(`http://localhost:${server.address().port}`);
|
|
const req = client.request();
|
|
|
|
req.on('response', common.mustCall((headers) => {
|
|
assert.strictEqual(headers[':status'], 404);
|
|
}));
|
|
req.on('data', common.mustNotCall());
|
|
req.on('end', common.mustCall(() => {
|
|
client.destroy();
|
|
server.close();
|
|
}));
|
|
req.end();
|
|
});
|